Page MenuHomePhabricator
Differential D10209

[lib] Remove simple usages of `LegacyRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Dec 6 2023, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 2:49 PM
Unknown Object (File)
Wed, Mar 19, 7:18 PM
Unknown Object (File)
Wed, Mar 19, 7:18 PM
Unknown Object (File)
Wed, Mar 19, 7:18 PM
Unknown Object (File)
Wed, Mar 19, 7:18 PM
Unknown Object (File)
Fri, Mar 7, 7:39 AM
Unknown Object (File)
Feb 23 2025, 11:35 PM
Unknown Object (File)
Feb 21 2025, 2:10 PM
View All 90 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM067235503820: [lib] Remove simple usages of `LegacyRawThreadInfo`
Summary

Straightforward removal of LegacyRawThreadInfo where there weren't recursive flow issues.

Depends on D10198

Test Plan

Flow/CI/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
reducers/
4 lines
selectors/
4 lines

Diff 34559

View Options

lib/reducers/integrity-reducer.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines
View Options

lib/selectors/thread-selectors.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines