Page MenuHomePhabricator
Differential D10209

[lib] Remove simple usages of `LegacyRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Dec 6 2023, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 12:54 AM
Unknown Object (File)
Wed, Apr 16, 7:09 PM
Unknown Object (File)
Wed, Apr 16, 2:27 AM
Unknown Object (File)
Wed, Apr 16, 2:26 AM
Unknown Object (File)
Tue, Apr 15, 11:02 PM
Unknown Object (File)
Tue, Apr 15, 9:39 AM
Unknown Object (File)
Thu, Apr 10, 12:07 PM
Unknown Object (File)
Wed, Apr 9, 11:57 AM
View All 100 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM067235503820: [lib] Remove simple usages of `LegacyRawThreadInfo`
Summary

Straightforward removal of LegacyRawThreadInfo where there weren't recursive flow issues.

Depends on D10198

Test Plan

Flow/CI/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
reducers/
4 lines
selectors/
4 lines

Diff 34559

View Options

lib/reducers/integrity-reducer.js

Show First 20 Lines • Show All 289 Lines • ▼ Show 20 Lines if (
typeof document !== 'undefined' && typeof document !== 'undefined' &&
document && document &&
'hasFocus' in document && 'hasFocus' in document &&
document.hasFocus() && document.hasFocus() &&
!state.navInfo.pendingThread && !state.navInfo.pendingThread &&
state.threadStore.threadInfos[activeThread].currentUser.unread state.threadStore.threadInfos[activeThread].currentUser.unread
) { ) {
// Makes sure a currently focused thread is never unread // Makes sure a currently focused thread is never unread
const activeThreadInfo = state.threadStore.threadInfos[activeThread];
// TODO (atul): Try to get rid of this ridiculous branching.
if (activeThreadInfo.minimallyEncoded) {
updateActiveThreadOps.push({ updateActiveThreadOps.push({
type: 'replace', type: 'replace',
payload: { payload: {
id: activeThread, id: activeThread,
threadInfo: { threadInfo: {
...state.threadStore.threadInfos[activeThread], ...activeThreadInfo,
currentUser: { currentUser: {
...state.threadStore.threadInfos[activeThread].currentUser, ...activeThreadInfo.currentUser,
unread: false, unread: false,
}, },
}, },
}, },
}); });
} else {
updateActiveThreadOps.push({
type: 'replace',
payload: {
id: activeThread,
threadInfo: {
...activeThreadInfo,
currentUser: {
...activeThreadInfo.currentUser,
unread: false,
},
},
},
});
}
} }
const oldActiveThread = activeThreadSelector(oldState); const oldActiveThread = activeThreadSelector(oldState);
if ( if (
activeThread && activeThread &&
oldActiveThread !== activeThread && oldActiveThread !== activeThread &&
state.messageStore.threads[activeThread] state.messageStore.threads[activeThread]
) { ) {
Show All 37 Lines
View Options

lib/selectors/thread-selectors.js

Show First 20 Lines • Show All 289 Lines • ▼ Show 20 Lines if (
typeof document !== 'undefined' && typeof document !== 'undefined' &&
document && document &&
'hasFocus' in document && 'hasFocus' in document &&
document.hasFocus() && document.hasFocus() &&
!state.navInfo.pendingThread && !state.navInfo.pendingThread &&
state.threadStore.threadInfos[activeThread].currentUser.unread state.threadStore.threadInfos[activeThread].currentUser.unread
) { ) {
// Makes sure a currently focused thread is never unread // Makes sure a currently focused thread is never unread
const activeThreadInfo = state.threadStore.threadInfos[activeThread];
// TODO (atul): Try to get rid of this ridiculous branching.
if (activeThreadInfo.minimallyEncoded) {
updateActiveThreadOps.push({ updateActiveThreadOps.push({
type: 'replace', type: 'replace',
payload: { payload: {
id: activeThread, id: activeThread,
threadInfo: { threadInfo: {
...state.threadStore.threadInfos[activeThread], ...activeThreadInfo,
currentUser: { currentUser: {
...state.threadStore.threadInfos[activeThread].currentUser, ...activeThreadInfo.currentUser,
unread: false, unread: false,
}, },
}, },
}, },
}); });
} else {
updateActiveThreadOps.push({
type: 'replace',
payload: {
id: activeThread,
threadInfo: {
...activeThreadInfo,
currentUser: {
...activeThreadInfo.currentUser,
unread: false,
},
},
},
});
}
} }
const oldActiveThread = activeThreadSelector(oldState); const oldActiveThread = activeThreadSelector(oldState);
if ( if (
activeThread && activeThread &&
oldActiveThread !== activeThread && oldActiveThread !== activeThread &&
state.messageStore.threads[activeThread] state.messageStore.threads[activeThread]
) { ) {
Show All 37 Lines