Page MenuHomePhabricator

[lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo` argument
ClosedPublic

Authored by atul on Dec 10 2023, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 1:05 PM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Tue, Nov 5, 10:02 PM
Unknown Object (File)
Tue, Nov 5, 10:01 PM
Unknown Object (File)
Tue, Nov 5, 7:44 PM
Unknown Object (File)
Wed, Oct 30, 8:13 AM
Unknown Object (File)
Oct 15 2024, 8:50 PM
Unknown Object (File)
Oct 15 2024, 8:50 PM
Subscribers
None

Details

Summary

This will definitely be tidied up in subsequent diff or after rebasing... but this unblocks some keyserver work that I wanted to go ahead and put up ASAP.


Depends on D10284

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Dec 10 2023, 7:02 PM
ashoat added inline comments.
lib/shared/thread-utils.js
899 ↗(On Diff #34465)

I don't think this counts as "ridiculous" branching. It's necessary because there are indeed differences in the two, such as getCurrentUser vs. getMinimallyEncodedCurrentUser

Nit, but can you maybe remove "ridiculous" here?

This revision is now accepted and ready to land.Dec 11 2023, 11:18 AM
lib/shared/thread-utils.js
899 ↗(On Diff #34465)

Yeah that's fair, this might be unavoidable. Will remove comment altogether for now.