[lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo` argument
ClosedPublic
Actions

Authored by atul on Dec 10 2023, 7:00 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMe87c28f8156f: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo`…

Summary

This will definitely be tidied up in subsequent diff or after rebasing... but this unblocks some keyserver work that I wanted to go ahead and put up ASAP.

Depends on D10284

Test Plan

CI/flow/etc.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 10 2023, 7:00 PM

atul published this revision for review.Dec 10 2023, 7:02 PM

Harbormaster completed remote builds in B24931: Diff 34465.Dec 10 2023, 7:19 PM

atul added a child revision: D10286: [keyserver] Update `rawThreadInfoFromServerThreadInfo` to support `minimallyEncodePermissions` option.Dec 10 2023, 7:22 PM

atul mentioned this in D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.Dec 11 2023, 9:39 AM

ashoat accepted this revision.Dec 11 2023, 11:18 AM

ashoat added inline comments.

lib/shared/thread-utils.js
899 ↗	(On Diff #34465)	I don't think this counts as "ridiculous" branching. It's necessary because there are indeed differences in the two, such as `getCurrentUser` vs. `getMinimallyEncodedCurrentUser` Nit, but can you maybe remove "ridiculous" here?