Page MenuHomePhabricator
Differential D10285

[lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo` argument
ClosedPublic
Actions

Authored by atul on Dec 10 2023, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 1:05 PM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Tue, Nov 5, 10:02 PM
Unknown Object (File)
Tue, Nov 5, 10:01 PM
Unknown Object (File)
Tue, Nov 5, 7:44 PM
Unknown Object (File)
Wed, Oct 30, 8:13 AM
Unknown Object (File)
Oct 15 2024, 8:50 PM
Unknown Object (File)
Oct 15 2024, 8:50 PM
View All 60 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMe87c28f8156f: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo`…
Summary

This will definitely be tidied up in subsequent diff or after rebasing... but this unblocks some keyserver work that I wanted to go ahead and put up ASAP.

Depends on D10284

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 10 2023, 7:00 PM
atul published this revision for review.Dec 10 2023, 7:02 PM
Harbormaster completed remote builds in B24931: Diff 34465.Dec 10 2023, 7:19 PM
atul added a child revision: D10286: [keyserver] Update `rawThreadInfoFromServerThreadInfo` to support `minimallyEncodePermissions` option.Dec 10 2023, 7:22 PM
atul mentioned this in D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.Dec 11 2023, 9:39 AM
ashoat accepted this revision.Dec 11 2023, 11:18 AM
ashoat added inline comments.
lib/shared/thread-utils.js
899

I don't think this counts as "ridiculous" branching. It's necessary because there are indeed differences in the two, such as getCurrentUser vs. getMinimallyEncodedCurrentUser

Nit, but can you maybe remove "ridiculous" here?

This revision is now accepted and ready to land.Dec 11 2023, 11:18 AM
atul added inline comments.Dec 13 2023, 3:11 PM
lib/shared/thread-utils.js
899

Yeah that's fair, this might be unavoidable. Will remove comment altogether for now.

atul updated this revision to Diff 34612.Dec 13 2023, 3:12 PM

address feedback

Harbormaster completed remote builds in B25052: Diff 34612.Dec 13 2023, 4:13 PM
Closed by commit rCOMMe87c28f8156f: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo`… (authored by atul). · Explain WhyDec 14 2023, 1:03 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe87c28f8156f: [lib] Naively update `threadInfoFromRawThreadInfo` to support `RawThreadInfo`….

Revision Contents
Changeset List

PathSize
lib/
shared/
71 lines

Diff 34465

View Options

lib/shared/thread-utils.js

Loading...