Page MenuHomePhabricator

[lib][keyserver] Replace `legacyRawThreadInfoValidator` with `rawThreadInfoValidator`
ClosedPublic

Authored by atul on Dec 11 2023, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 1:54 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Unknown Object (File)
Oct 15 2024, 10:24 PM
Unknown Object (File)
Oct 5 2024, 9:25 PM
Unknown Object (File)
Sep 9 2024, 9:31 PM
Subscribers

Details

Summary

To address keyserver validation issues during testing.

NOTE: Had issue with threadStoreValidator but deferring for now since that's only relevant for web (called from initialReduxStateValidator) and we're focusing on native for now.

Depends on D10286

Test Plan
  1. Login works
  2. Thread updates work
  3. Assuming the others work

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Dec 11 2023, 12:10 PM

How come legacyRawThreadInfoValidator isn't removed here? Is it still needed somewhere?

This revision is now accepted and ready to land.Dec 11 2023, 12:24 PM

How come legacyRawThreadInfoValidator isn't removed here? Is it still needed somewhere?

It isn't removed because it's part of rawThreadInfoValidator which is a union of legacyRawThreadInfoValidator and minimallyEncodedRawThreadInfoValidator.

It's also used in keyserver/scripts/generate-converter-from-validator.js, which I think is a one-off script and doesn't need to be updated CC @michal

It's also used in keyserver/scripts/generate-converter-from-validator.js, which I think is a one-off script and doesn't need to be updated CC @michal

Yeah it was used to migrate generate migrations from validators. We won't need to generate any new migrations.