Page MenuHomePhabricator
Differential D10294

[lib][keyserver] Replace `legacyRawThreadInfoValidator` with `rawThreadInfoValidator`
ClosedPublic
Actions

Authored by atul on Dec 11 2023, 11:58 AM.
Tags
None
Referenced Files
F4951475: D10294.diff
Thu, Mar 20, 2:54 PM
F4948084: D10294.id34679.diff
Wed, Mar 19, 7:24 PM
F4948083: D10294.id34614.diff
Wed, Mar 19, 7:24 PM
F4948082: D10294.id34488.diff
Wed, Mar 19, 7:24 PM
F4948080: D10294.id.diff
Wed, Mar 19, 7:24 PM
Unknown Object (File)
Sat, Mar 8, 10:23 PM
Unknown Object (File)
Fri, Feb 21, 11:33 PM
Unknown Object (File)
Fri, Feb 21, 1:09 PM
View All 88 Files
Subscribers
michal

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM942ab94696ec: [lib][keyserver] Replace `legacyRawThreadInfoValidator` with…
Summary

To address keyserver validation issues during testing.

NOTE: Had issue with threadStoreValidator but deferring for now since that's only relevant for web (called from initialReduxStateValidator) and we're focusing on native for now.

Depends on D10286

Test Plan
  1. Login works
  2. Thread updates work
  3. Assuming the others work

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 11 2023, 11:58 AM
atul published this revision for review.Dec 11 2023, 12:10 PM
Harbormaster completed remote builds in B24951: Diff 34488.Dec 11 2023, 12:18 PM
ashoat accepted this revision.Dec 11 2023, 12:24 PM

How come legacyRawThreadInfoValidator isn't removed here? Is it still needed somewhere?

This revision is now accepted and ready to land.Dec 11 2023, 12:24 PM
atul added a subscriber: michal.Dec 11 2023, 12:40 PM
In D10294#298044, @ashoat wrote:

How come legacyRawThreadInfoValidator isn't removed here? Is it still needed somewhere?

It isn't removed because it's part of rawThreadInfoValidator which is a union of legacyRawThreadInfoValidator and minimallyEncodedRawThreadInfoValidator.

It's also used in keyserver/scripts/generate-converter-from-validator.js, which I think is a one-off script and doesn't need to be updated CC @michal

atul added a child revision: D10295: [keyserver] Move `threadStoreValidator` to `redux-state-responders`.Dec 11 2023, 12:41 PM
michal added a comment.Dec 12 2023, 3:11 AM

It's also used in keyserver/scripts/generate-converter-from-validator.js, which I think is a one-off script and doesn't need to be updated CC @michal

Yeah it was used to migrate generate migrations from validators. We won't need to generate any new migrations.

atul updated this revision to Diff 34614.Dec 13 2023, 3:17 PM

last rebase pass

Harbormaster completed remote builds in B25054: Diff 34614.Dec 13 2023, 4:13 PM
Closed by commit rCOMM942ab94696ec: [lib][keyserver] Replace `legacyRawThreadInfoValidator` with… (authored by atul). · Explain WhyDec 14 2023, 1:03 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM942ab94696ec: [lib][keyserver] Replace `legacyRawThreadInfoValidator` with….

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
6 lines
3 lines
lib/
shared/
updates/
8 lines
8 lines
types/
8 lines
8 lines

Diff 34679

View Options

keyserver/src/responders/thread-responders.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

keyserver/src/responders/user-responders.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/shared/updates/join-thread-spec.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/shared/updates/update-thread-spec.js

Show All 24 Lines "devDependencies": {
"@babel/cli": "^7.23.4", "@babel/cli": "^7.23.4",
"@babel/core": "^7.23.7", "@babel/core": "^7.23.7",
"@babel/node": "^7.22.19", "@babel/node": "^7.22.19",
"@babel/plugin-syntax-dynamic-import": "^7.8.3", "@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-class-properties": "^7.23.3", "@babel/plugin-transform-class-properties": "^7.23.3",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4", "@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-object-rest-spread": "^7.23.4", "@babel/plugin-transform-object-rest-spread": "^7.23.4",
"@babel/plugin-transform-optional-chaining": "^7.23.4", "@babel/plugin-transform-optional-chaining": "^7.23.4",
"@babel/plugin-transform-private-methods": "^7.24.1",
"@babel/plugin-transform-runtime": "^7.23.7", "@babel/plugin-transform-runtime": "^7.23.7",
"@babel/preset-env": "^7.23.7", "@babel/preset-env": "^7.23.7",
"@babel/preset-flow": "^7.23.3", "@babel/preset-flow": "^7.23.3",
"@babel/preset-react": "^7.23.3", "@babel/preset-react": "^7.23.3",
"babel-jest": "^29.7.0", "babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "2.2.1", "babel-plugin-transform-import-meta": "2.2.1",
"chokidar-cli": "^2.1.0", "chokidar-cli": "^2.1.0",
"concurrently": "^5.3.0", "concurrently": "^5.3.0",
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines
View Options

lib/types/request-types.js

Loading...
View Options

lib/types/socket-types.js

Loading...