Page MenuHomePhabricator
Differential D10286

[keyserver] Update `rawThreadInfoFromServerThreadInfo` to support `minimallyEncodePermissions` option
ClosedPublic
Actions

Authored by atul on Dec 10 2023, 7:22 PM.
Tags
None
Referenced Files
F1716766: D10286.id34613.diff
Wed, May 8, 2:19 AM
Unknown Object (File)
Mon, May 6, 6:02 PM
Unknown Object (File)
Mon, May 6, 5:18 PM
Unknown Object (File)
Mon, May 6, 3:12 PM
Unknown Object (File)
Thu, May 2, 4:19 AM
Unknown Object (File)
Mar 5 2024, 3:15 PM
Unknown Object (File)
Mar 5 2024, 3:15 PM
Unknown Object (File)
Mar 5 2024, 3:15 PM
View All 19 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMab7a55637495: [keyserver] Update `rawThreadInfoFromServerThreadInfo` to support…
Summary

This is the diff that finally allows keyserver to send the new "minimally encoded" permissions to new clients.

We introduce minimallyEncodePermissions option, which for now will be set to NATIVE FUTURE_CODE_VERSION. Once we have a version of client that fully supports minimally encoded permissions, we will update this setting.

Depends on D10285

Test Plan
  1. Will set breakpoint in keyserver and ensure that rawThreadInfos are constructed as expected.

642b40.png (2×2 px, 531 KB)

  1. Will check Redux dev tools on corresponding client to ensure that minimally encoded permissions appear as expected.
  2. Will play around with the native app and make sure that permissions checks continue to behave as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 10 2023, 7:22 PM
atul published this revision for review.Dec 10 2023, 7:22 PM
Harbormaster completed remote builds in B24932: Diff 34466.Dec 10 2023, 7:41 PM
atul edited the test plan for this revision. (Show Details)Dec 10 2023, 7:55 PM
rohan accepted this revision.Dec 11 2023, 7:26 AM
This revision is now accepted and ready to land.Dec 11 2023, 7:26 AM
atul updated this revision to Diff 34487.Dec 11 2023, 11:42 AM

fix

atul added a child revision: D10294: [lib][keyserver] Replace `legacyRawThreadInfoValidator` with `rawThreadInfoValidator`.Dec 11 2023, 11:58 AM
Harbormaster completed remote builds in B24950: Diff 34487.Dec 11 2023, 12:01 PM
atul updated this revision to Diff 34613.Dec 13 2023, 3:16 PM

last rebase pass

Harbormaster completed remote builds in B25053: Diff 34613.Dec 13 2023, 4:05 PM
Closed by commit rCOMMab7a55637495: [keyserver] Update `rawThreadInfoFromServerThreadInfo` to support… (authored by atul). · Explain WhyDec 14 2023, 1:03 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMab7a55637495: [keyserver] Update `rawThreadInfoFromServerThreadInfo` to support….

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
18 lines
responders/
3 lines
lib/
shared/
11 lines

Diff 34678

View Options

keyserver/src/fetchers/thread-fetchers.js

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...