Page MenuHomePhabricator

[keyserver] Update `rawThreadInfoFromServerThreadInfo` to support `minimallyEncodePermissions` option
ClosedPublic

Authored by atul on Dec 10 2023, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 20, 6:33 AM
Unknown Object (File)
Tue, Oct 15, 10:25 PM
Unknown Object (File)
Tue, Oct 15, 10:25 PM
Unknown Object (File)
Tue, Oct 15, 10:25 PM
Unknown Object (File)
Tue, Oct 15, 10:25 PM
Unknown Object (File)
Tue, Oct 15, 10:25 PM
Unknown Object (File)
Tue, Oct 15, 10:24 PM
Unknown Object (File)
Sep 30 2024, 5:46 PM
Subscribers
None

Details

Summary

This is the diff that finally allows keyserver to send the new "minimally encoded" permissions to new clients.

We introduce minimallyEncodePermissions option, which for now will be set to NATIVE FUTURE_CODE_VERSION. Once we have a version of client that fully supports minimally encoded permissions, we will update this setting.


Depends on D10285

Test Plan
  1. Will set breakpoint in keyserver and ensure that rawThreadInfos are constructed as expected.

642b40.png (2×2 px, 531 KB)

  1. Will check Redux dev tools on corresponding client to ensure that minimally encoded permissions appear as expected.
  2. Will play around with the native app and make sure that permissions checks continue to behave as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Dec 10 2023, 7:22 PM
This revision is now accepted and ready to land.Dec 11 2023, 7:26 AM