Paths

Table of Contentst

-
lib/types/
-
types/
-
thread-types.js

Differential D10212

[lib] Update `Role[Deletion/Modification][Payload/Result]` to handle `RawThreadInfo`
ClosedPublic
Actions

Authored by atul on Dec 6 2023, 3:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 8, 7:56 AM

	Unknown Object (File)
	Sat, Apr 5, 7:05 PM

	Unknown Object (File)
	Wed, Apr 2, 11:47 PM

	Unknown Object (File)
	Thu, Mar 20, 2:50 PM

	Unknown Object (File)
	Wed, Mar 19, 7:20 PM

	Unknown Object (File)
	Wed, Mar 19, 7:20 PM

	Unknown Object (File)
	Wed, Mar 19, 7:19 PM

	Unknown Object (File)
	Wed, Mar 12, 3:29 PM

View All 70 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM0e9dbe189c74: [lib] Update `Role[Deletion/Modification][Payload/Result]` to handle…

Summary

Continuing to refactor sites where we still have LegacyRawThreadInfo.

Depends on D10211

Test Plan

CI/flow/etc.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 6 2023, 3:08 PM

Harbormaster completed remote builds in B24837: Diff 34359.Dec 6 2023, 3:27 PM

atul requested review of this revision.Dec 6 2023, 3:27 PM

rohan accepted this revision.Dec 6 2023, 4:30 PM

This revision is now accepted and ready to land.Dec 6 2023, 4:30 PM

atul added a child revision: D10223: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`.Dec 7 2023, 8:15 AM

Closed by commit rCOMM0e9dbe189c74: [lib] Update `Role[Deletion/Modification][Payload/Result]` to handle… (authored by atul). · Explain WhyDec 12 2023, 7:52 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0e9dbe189c74: [lib] Update `Role[Deletion/Modification][Payload/Result]` to handle….

Revision Contents
Changeset List

Path

Size

lib/

types/

thread-types.js

8 lines

Diff 34562

lib/types/thread-types.js

	Show All 31 Lines
	} from '../../navigation/route-names.js';			} from '../../navigation/route-names.js';
	import { useStyles } from '../../themes/colors.js';			import { useStyles } from '../../themes/colors.js';

	export type AvatarSelectionParams = {			export type AvatarSelectionParams = {
	+userSelections: {			+userSelections: {
	+coolOrNerdMode: CoolOrNerdMode,			+coolOrNerdMode: CoolOrNerdMode,
	+keyserverURL: string,			+keyserverURL: string,
	+accountSelection: AccountSelection,			+accountSelection: AccountSelection,
				+farcasterID: ?string,
	},			},
	};			};

	type Props = {			type Props = {
	+navigation: RegistrationNavigationProp<'AvatarSelection'>,			+navigation: RegistrationNavigationProp<'AvatarSelection'>,
	+route: NavigationRoute<'AvatarSelection'>,			+route: NavigationRoute<'AvatarSelection'>,
	};			};
	function AvatarSelection(props: Props): React.Node {			function AvatarSelection(props: Props): React.Node {
	▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines