Page MenuHomePhabricator

[lib] Fix `threadPermissionsFromBitmaskHex` invariant
ClosedPublic

Authored by atul on Dec 11 2023, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 8:14 AM
Unknown Object (File)
Wed, Nov 6, 1:54 PM
Unknown Object (File)
Tue, Nov 5, 11:31 PM
Unknown Object (File)
Tue, Nov 5, 9:53 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Unknown Object (File)
Oct 15 2024, 10:25 PM
Subscribers
None

Details

Summary

Really shouldn't have made this mistake...

After moving things around to resolve circular dependency issue, I accidentally started using the tHexEncodedRolePermission check in threadPermissionsFromBitmaskHex instead of the tHexEncodedPermissionsBitmask check...

This required that we have >=3 hex characters, when there's no such minimum for thread permissions.

Caught this during native testing thanks to thread where permissions for some user were "3", which should have been valid.

I read through minimally-encoded-thread-permissions again very carefully to see if there were any other mistakes I could find. I think part of the reason for the error may have been the similar-ish naming of all the utilities/etc. I'll see if I can update those to be more clear.

Also went ahead and included unit test that would've caught the issue earlier.


Depends on D10295

Test Plan

Unit test, careful re-reading of threadPermissionsFromBitmaskHex.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable