Page MenuHomePhabricator
Differential D10296

[lib] Fix `threadPermissionsFromBitmaskHex` invariant
ClosedPublic
Actions

Authored by atul on Dec 11 2023, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 9:45 AM
Unknown Object (File)
Wed, Apr 16, 2:35 AM
Unknown Object (File)
Wed, Apr 16, 1:52 AM
Unknown Object (File)
Tue, Apr 15, 8:06 PM
Unknown Object (File)
Tue, Apr 15, 6:51 PM
Unknown Object (File)
Wed, Apr 9, 12:42 AM
Unknown Object (File)
Fri, Mar 28, 6:29 AM
Unknown Object (File)
Mar 21 2025, 10:53 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMMe40290b7161c: [lib] Fix `threadPermissionsFromBitmaskHex` invariant
Summary

Really shouldn't have made this mistake...

After moving things around to resolve circular dependency issue, I accidentally started using the tHexEncodedRolePermission check in threadPermissionsFromBitmaskHex instead of the tHexEncodedPermissionsBitmask check...

This required that we have >=3 hex characters, when there's no such minimum for thread permissions.

Caught this during native testing thanks to thread where permissions for some user were "3", which should have been valid.

I read through minimally-encoded-thread-permissions again very carefully to see if there were any other mistakes I could find. I think part of the reason for the error may have been the similar-ish naming of all the utilities/etc. I'll see if I can update those to be more clear.

Also went ahead and included unit test that would've caught the issue earlier.

Depends on D10295

Test Plan

Unit test, careful re-reading of threadPermissionsFromBitmaskHex.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 34578

View Options

lib/permissions/minimally-encoded-thread-permissions.js

Show All 15 Linesimport {
translateClientDBMessageInfoToRawMessageInfo, translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo, translateRawMessageInfoToClientDBMessageInfo,
translateClientDBThreadMessageInfos, translateClientDBThreadMessageInfos,
translateThreadMessageInfoToClientDBThreadMessageInfo, translateThreadMessageInfoToClientDBThreadMessageInfo,
type TranslatedThreadMessageInfos, type TranslatedThreadMessageInfos,
} from 'lib/utils/message-ops-utils.js'; } from 'lib/utils/message-ops-utils.js';
import { values, entries } from 'lib/utils/objects.js'; import { values, entries } from 'lib/utils/objects.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
deprecatedConvertClientDBThreadInfoToRawThreadInfo,
} from 'lib/utils/thread-ops-utils.js'; } from 'lib/utils/thread-ops-utils.js';
import type { AppState } from './state-types.js'; import type { AppState } from './state-types.js';
import { commCoreModule } from '../native-modules.js'; import { commCoreModule } from '../native-modules.js';
function updateClientDBThreadStoreThreadInfos( function updateClientDBThreadStoreThreadInfos(
state: AppState, state: AppState,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
Show All 27 Lines
} }
function createUpdateDBOpsForThreadStoreThreadInfos( function createUpdateDBOpsForThreadStoreThreadInfos(
clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>, clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
): $ReadOnlyArray<ClientDBThreadStoreOperation> { ): $ReadOnlyArray<ClientDBThreadStoreOperation> {
// Translate `ClientDBThreadInfo`s to `RawThreadInfo`s. // Translate `ClientDBThreadInfo`s to `RawThreadInfo`s.
const rawThreadInfos = clientDBThreadInfos.map( const rawThreadInfos = clientDBThreadInfos.map(
convertClientDBThreadInfoToRawThreadInfo, deprecatedConvertClientDBThreadInfoToRawThreadInfo,
); );
// Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`. // Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`.
const threadIDToThreadInfo = rawThreadInfos.reduce( const threadIDToThreadInfo = rawThreadInfos.reduce(
( (
acc: { [string]: LegacyRawThreadInfo }, acc: { [string]: LegacyRawThreadInfo },
threadInfo: LegacyRawThreadInfo, threadInfo: LegacyRawThreadInfo,
) => { ) => {
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines
View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Show All 15 Linesimport {
translateClientDBMessageInfoToRawMessageInfo, translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo, translateRawMessageInfoToClientDBMessageInfo,
translateClientDBThreadMessageInfos, translateClientDBThreadMessageInfos,
translateThreadMessageInfoToClientDBThreadMessageInfo, translateThreadMessageInfoToClientDBThreadMessageInfo,
type TranslatedThreadMessageInfos, type TranslatedThreadMessageInfos,
} from 'lib/utils/message-ops-utils.js'; } from 'lib/utils/message-ops-utils.js';
import { values, entries } from 'lib/utils/objects.js'; import { values, entries } from 'lib/utils/objects.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
deprecatedConvertClientDBThreadInfoToRawThreadInfo,
} from 'lib/utils/thread-ops-utils.js'; } from 'lib/utils/thread-ops-utils.js';
import type { AppState } from './state-types.js'; import type { AppState } from './state-types.js';
import { commCoreModule } from '../native-modules.js'; import { commCoreModule } from '../native-modules.js';
function updateClientDBThreadStoreThreadInfos( function updateClientDBThreadStoreThreadInfos(
state: AppState, state: AppState,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
Show All 27 Lines
} }
function createUpdateDBOpsForThreadStoreThreadInfos( function createUpdateDBOpsForThreadStoreThreadInfos(
clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>, clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
): $ReadOnlyArray<ClientDBThreadStoreOperation> { ): $ReadOnlyArray<ClientDBThreadStoreOperation> {
// Translate `ClientDBThreadInfo`s to `RawThreadInfo`s. // Translate `ClientDBThreadInfo`s to `RawThreadInfo`s.
const rawThreadInfos = clientDBThreadInfos.map( const rawThreadInfos = clientDBThreadInfos.map(
convertClientDBThreadInfoToRawThreadInfo, deprecatedConvertClientDBThreadInfoToRawThreadInfo,
); );
// Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`. // Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`.
const threadIDToThreadInfo = rawThreadInfos.reduce( const threadIDToThreadInfo = rawThreadInfos.reduce(
( (
acc: { [string]: LegacyRawThreadInfo }, acc: { [string]: LegacyRawThreadInfo },
threadInfo: LegacyRawThreadInfo, threadInfo: LegacyRawThreadInfo,
) => { ) => {
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines