Page MenuHomePhabricator
Differential D10275

[lib] Update remaining places in `lib` to support `RawThreadInfos`
ClosedPublic
Actions

Authored by atul on Dec 8 2023, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 2:54 PM
Unknown Object (File)
Wed, Mar 19, 7:24 PM
Unknown Object (File)
Wed, Mar 19, 7:24 PM
Unknown Object (File)
Wed, Mar 19, 7:24 PM
Unknown Object (File)
Wed, Mar 19, 7:24 PM
Unknown Object (File)
Sun, Mar 16, 9:20 AM
Unknown Object (File)
Fri, Mar 7, 8:59 AM
Unknown Object (File)
Mon, Mar 3, 9:17 AM
View All 90 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM47e706802def: [lib] Update remaining places in `lib` to support `RawThreadInfos`
Summary

Last couple spots where we mostly just need to swap out type names.

NOTE: CI is expected to fail. I got to a point in my local environment where all flow issues were resolved, but based on earlier fedback in the stack I'm breaking them down so things are easier to review.. even if that means that intermediate steps fail.

[skip-ci]

Depends on D10274

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Dec 8 2023, 12:56 PM
atul created this revision.
Harbormaster completed remote builds in B24920: Diff 34454.Dec 8 2023, 12:56 PM
atul retitled this revision from [lib] Update remaining places in `lib` to support `LegacyRawThreadInfos` to [lib] Update remaining places in `lib` to support `RawThreadInfos`.Dec 8 2023, 1:08 PM
atul added a child revision: D10277: [web] Update `validateStateAndProcessDBOperations` to handle `RawThreadInfos`.Dec 8 2023, 1:11 PM
rohan accepted this revision.Dec 10 2023, 8:14 AM
This revision is now accepted and ready to land.Dec 10 2023, 8:14 AM
atul updated this revision to Diff 34605.Dec 13 2023, 2:59 PM

last rebase pass

Harbormaster completed remote builds in B25045: Diff 34605.Dec 13 2023, 2:59 PM
Closed by commit rCOMM47e706802def: [lib] Update remaining places in `lib` to support `RawThreadInfos` (authored by atul). · Explain WhyDec 14 2023, 12:49 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM47e706802def: [lib] Update remaining places in `lib` to support `RawThreadInfos`.

Revision Contents
Changeset List

PathSize
lib/
actions/
4 lines
ops/
10 lines
reducers/
12 lines

Diff 34669

View Options

lib/actions/user-actions.js

Show First 20 Lines • Show All 119 Lines • ▼ Show 20 LinesversionBroadcast.onmessage = (event: MessageEvent) => {
} }
}; };
// Start initializing the shared worker immediately // Start initializing the shared worker immediately
void getCommSharedWorker(); void getCommSharedWorker();
const queryClient = new QueryClient(); const queryClient = new QueryClient();
const wagmiConfig = getWagmiConfig({ includeInjectedWallet: true }); const wagmiConfig = getWagmiConfig([
'injected',
'rainbow',
'metamask',
'coinbase',
'walletconnect',
]);
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
}; };
type Props = { type Props = {
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines
View Options

lib/ops/thread-store-ops.js

Show First 20 Lines • Show All 119 Lines • ▼ Show 20 LinesversionBroadcast.onmessage = (event: MessageEvent) => {
} }
}; };
// Start initializing the shared worker immediately // Start initializing the shared worker immediately
void getCommSharedWorker(); void getCommSharedWorker();
const queryClient = new QueryClient(); const queryClient = new QueryClient();
const wagmiConfig = getWagmiConfig({ includeInjectedWallet: true }); const wagmiConfig = getWagmiConfig([
'injected',
'rainbow',
'metamask',
'coinbase',
'walletconnect',
]);
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
}; };
type Props = { type Props = {
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines
View Options

lib/reducers/message-reducer.js

Show First 20 Lines • Show All 119 Lines • ▼ Show 20 LinesversionBroadcast.onmessage = (event: MessageEvent) => {
} }
}; };
// Start initializing the shared worker immediately // Start initializing the shared worker immediately
void getCommSharedWorker(); void getCommSharedWorker();
const queryClient = new QueryClient(); const queryClient = new QueryClient();
const wagmiConfig = getWagmiConfig({ includeInjectedWallet: true }); const wagmiConfig = getWagmiConfig([
'injected',
'rainbow',
'metamask',
'coinbase',
'walletconnect',
]);
type BaseProps = { type BaseProps = {
+location: { +location: {
+pathname: string, +pathname: string,
... ...
}, },
}; };
type Props = { type Props = {
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines