Page MenuHomePhabricator

[lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`
ClosedPublic

Authored by atul on Dec 6 2023, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 3:04 PM
Unknown Object (File)
Fri, Nov 1, 8:36 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:52 PM
Unknown Object (File)
Tue, Oct 15, 11:51 PM
Unknown Object (File)
Tue, Oct 15, 11:51 PM
Unknown Object (File)
Sep 4 2024, 4:11 PM
Subscribers
None

Details

Summary

Introduce deprecatedConvertClientDBThreadInfoToRawThreadInfo which turns a ClientDB representation of RawThreadInfo into LegacyRawThreadInfo.

The reason for this function, as described in D10198, is to maintain correctness of existing Redux migrations.

(As an aside, Redux migrations would be a great thing to write unit tests for because often our assumptions about "current state of the codebase" when modifying helper functions don't apply to migrations and can break them. I just happened to notice convertClientDBThreadInfoToRawThreadInfo when looking at creating a new Redux migration and realized this would break old migrations.)


Depends on D10209

Test Plan

NA/CI/flow

NOTE: Disabled two unit tests for now, will re-enable after updating test data. This is definitely a flow I'm planning on testing so put in TODOs for now... thought happy to create Linear tasks if that'd be preferred.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Dec 6 2023, 2:42 PM
This revision is now accepted and ready to land.Dec 8 2023, 5:17 AM

thought happy to create Linear tasks if that'd be prefered.

Yes please!

lib/utils/thread-ops-utils.test.js
399 ↗(On Diff #34357)

TIL about xdescribe

This revision was landed with ongoing or failed builds.Dec 13 2023, 1:34 PM
This revision was automatically updated to reflect the committed changes.