Page MenuHomePhabricator
Differential D10225

[lib] Rip `LegacyRawThreadInfos` out of `lib/selector`
ClosedPublic
Actions

Authored by atul on Dec 7 2023, 9:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 1:05 PM
Unknown Object (File)
Tue, Apr 15, 11:18 AM
Unknown Object (File)
Tue, Apr 15, 1:16 AM
Unknown Object (File)
Mon, Apr 14, 9:54 AM
Unknown Object (File)
Wed, Apr 9, 12:40 AM
Unknown Object (File)
Tue, Apr 8, 8:30 PM
Unknown Object (File)
Tue, Apr 8, 8:28 PM
Unknown Object (File)
Thu, Mar 27, 4:37 PM
View All 80 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM4c7b8986f148: [lib] Rip `LegacyRawThreadInfos` out of `lib/selector`
Summary

Continuation of D10224

Depends on D10224

Test Plan

CI/flow/etc.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
selectors/
21 lines
12 lines

Diff 34591

View Options

lib/selectors/thread-selectors.js

Show All 15 Linesimport {
translateClientDBMessageInfoToRawMessageInfo, translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo, translateRawMessageInfoToClientDBMessageInfo,
translateClientDBThreadMessageInfos, translateClientDBThreadMessageInfos,
translateThreadMessageInfoToClientDBThreadMessageInfo, translateThreadMessageInfoToClientDBThreadMessageInfo,
type TranslatedThreadMessageInfos, type TranslatedThreadMessageInfos,
} from 'lib/utils/message-ops-utils.js'; } from 'lib/utils/message-ops-utils.js';
import { values, entries } from 'lib/utils/objects.js'; import { values, entries } from 'lib/utils/objects.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
deprecatedConvertClientDBThreadInfoToRawThreadInfo,
} from 'lib/utils/thread-ops-utils.js'; } from 'lib/utils/thread-ops-utils.js';
import type { AppState } from './state-types.js'; import type { AppState } from './state-types.js';
import { commCoreModule } from '../native-modules.js'; import { commCoreModule } from '../native-modules.js';
function updateClientDBThreadStoreThreadInfos( function updateClientDBThreadStoreThreadInfos(
state: AppState, state: AppState,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
Show All 27 Lines
} }
function createUpdateDBOpsForThreadStoreThreadInfos( function createUpdateDBOpsForThreadStoreThreadInfos(
clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>, clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
): $ReadOnlyArray<ClientDBThreadStoreOperation> { ): $ReadOnlyArray<ClientDBThreadStoreOperation> {
// Translate `ClientDBThreadInfo`s to `RawThreadInfo`s. // Translate `ClientDBThreadInfo`s to `RawThreadInfo`s.
const rawThreadInfos = clientDBThreadInfos.map( const rawThreadInfos = clientDBThreadInfos.map(
convertClientDBThreadInfoToRawThreadInfo, deprecatedConvertClientDBThreadInfoToRawThreadInfo,
); );
// Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`. // Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`.
const threadIDToThreadInfo = rawThreadInfos.reduce( const threadIDToThreadInfo = rawThreadInfos.reduce(
( (
acc: { [string]: LegacyRawThreadInfo }, acc: { [string]: LegacyRawThreadInfo },
threadInfo: LegacyRawThreadInfo, threadInfo: LegacyRawThreadInfo,
) => { ) => {
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines
View Options

lib/selectors/user-selectors.js

Show All 15 Linesimport {
translateClientDBMessageInfoToRawMessageInfo, translateClientDBMessageInfoToRawMessageInfo,
translateRawMessageInfoToClientDBMessageInfo, translateRawMessageInfoToClientDBMessageInfo,
translateClientDBThreadMessageInfos, translateClientDBThreadMessageInfos,
translateThreadMessageInfoToClientDBThreadMessageInfo, translateThreadMessageInfoToClientDBThreadMessageInfo,
type TranslatedThreadMessageInfos, type TranslatedThreadMessageInfos,
} from 'lib/utils/message-ops-utils.js'; } from 'lib/utils/message-ops-utils.js';
import { values, entries } from 'lib/utils/objects.js'; import { values, entries } from 'lib/utils/objects.js';
import { import {
convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo, convertRawThreadInfoToClientDBThreadInfo,
deprecatedConvertClientDBThreadInfoToRawThreadInfo,
} from 'lib/utils/thread-ops-utils.js'; } from 'lib/utils/thread-ops-utils.js';
import type { AppState } from './state-types.js'; import type { AppState } from './state-types.js';
import { commCoreModule } from '../native-modules.js'; import { commCoreModule } from '../native-modules.js';
function updateClientDBThreadStoreThreadInfos( function updateClientDBThreadStoreThreadInfos(
state: AppState, state: AppState,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
Show All 27 Lines
} }
function createUpdateDBOpsForThreadStoreThreadInfos( function createUpdateDBOpsForThreadStoreThreadInfos(
clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>, clientDBThreadInfos: $ReadOnlyArray<ClientDBThreadInfo>,
migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos, migrationFunc: ThreadStoreThreadInfos => ThreadStoreThreadInfos,
): $ReadOnlyArray<ClientDBThreadStoreOperation> { ): $ReadOnlyArray<ClientDBThreadStoreOperation> {
// Translate `ClientDBThreadInfo`s to `RawThreadInfo`s. // Translate `ClientDBThreadInfo`s to `RawThreadInfo`s.
const rawThreadInfos = clientDBThreadInfos.map( const rawThreadInfos = clientDBThreadInfos.map(
convertClientDBThreadInfoToRawThreadInfo, deprecatedConvertClientDBThreadInfoToRawThreadInfo,
); );
// Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`. // Convert `rawThreadInfo`s to a map of `threadID` => `threadInfo`.
const threadIDToThreadInfo = rawThreadInfos.reduce( const threadIDToThreadInfo = rawThreadInfos.reduce(
( (
acc: { [string]: LegacyRawThreadInfo }, acc: { [string]: LegacyRawThreadInfo },
threadInfo: LegacyRawThreadInfo, threadInfo: LegacyRawThreadInfo,
) => { ) => {
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines