Page MenuHomePhabricator
Differential D10223

[lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`
ClosedPublic
Actions

Authored by atul on Dec 7 2023, 8:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 11:41 PM
Unknown Object (File)
Mar 5 2024, 3:52 PM
Unknown Object (File)
Mar 5 2024, 3:52 PM
Unknown Object (File)
Mar 5 2024, 3:52 PM
Unknown Object (File)
Mar 5 2024, 3:52 PM
Unknown Object (File)
Mar 5 2024, 3:52 PM
Unknown Object (File)
Mar 5 2024, 3:51 PM
Unknown Object (File)
Mar 5 2024, 3:51 PM
View All 25 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM347740333ec0: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`
rCOMM04035ac45ee1: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`
Summary

Updated types related to thread state sync spec to handle RawThreadInfo[s] instead of more specific LegacyRawThreadInfo[s].

Depends on D10212

Test Plan

Flow/CI/etc. Will test state sync + set breakpoints to ensure that behavior continues to be as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 7 2023, 8:15 AM
atul published this revision for review.Dec 7 2023, 8:18 AM
Harbormaster failed remote builds in B24855: Diff 34377!Dec 7 2023, 8:57 AM
atul added a child revision: D10224: [lib] Replace `LegacyRawThreadInfoS` with `RawThreadInfoS` where simple.Dec 7 2023, 8:59 AM
Harbormaster completed remote builds in B24855: Diff 34377.Dec 7 2023, 9:19 AM
rohan accepted this revision.Dec 7 2023, 10:01 AM
This revision is now accepted and ready to land.Dec 7 2023, 10:01 AM
atul updated this revision to Diff 34560.Dec 12 2023, 7:28 PM

land what's easy to land to reduce stack

Harbormaster completed remote builds in B25017: Diff 34560.Dec 12 2023, 7:48 PM
Closed by commit rCOMM04035ac45ee1: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]` (authored by atul). · Explain WhyDec 12 2023, 7:52 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM04035ac45ee1: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`.
atul added a reverting change: rCOMM2c2da0fd59e0: Revert "[lib] Update `threads-state-sync-spec` to use more general….Dec 12 2023, 8:08 PM
atul reopened this revision.Dec 12 2023, 8:09 PM
This revision is now accepted and ready to land.Dec 12 2023, 8:09 PM
atul updated this revision to Diff 34575.Dec 13 2023, 12:53 PM

fix and re-land

This revision was landed with ongoing or failed builds.Dec 13 2023, 12:56 PM
Closed by commit rCOMM347740333ec0: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM347740333ec0: [lib] Update `threads-state-sync-spec` to use more general `RawThreadInfo[s]`.
Harbormaster completed remote builds in B25026: Diff 34575.Dec 13 2023, 1:25 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
shared/
state-sync/
8 lines
lib/
shared/
state-sync/
16 lines
types/
12 lines

Diff 34576

View Options

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Loading...
View Options

lib/shared/state-sync/threads-state-sync-spec.js

Loading...
View Options

lib/types/report-types.js

Loading...