Paths

Table of Contentst

[lib] Introduce `getRelativeMemberInfos` which helps narrow `[Legacy]RawThreadInfos`
AbandonedPublic
Actions

Authored by atul on Dec 8 2023, 12:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 10, 12:06 PM

	Unknown Object (File)
	Mar 6 2024, 10:52 PM

	Unknown Object (File)
	Mar 5 2024, 3:34 PM

	Unknown Object (File)
	Mar 5 2024, 3:34 PM

	Unknown Object (File)
	Mar 5 2024, 3:34 PM

	Unknown Object (File)
	Dec 27 2023, 6:08 PM

	Unknown Object (File)
	Dec 26 2023, 8:48 PM

	Unknown Object (File)
	Dec 26 2023, 1:44 AM

View All 11 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Summary

This helper function really just wraps getMinimallyEncodedRelativeMemberInfos and getLegacyRelativeMemberInfos and helps narrow arg/return types. More in-depth discussion in D10235 when those utilities were introduced.

Depends on D10271

Test Plan

CI/flow/etc.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 8 2023, 12:25 PM

atul published this revision for review.Dec 8 2023, 12:26 PM

Harbormaster failed remote builds in B24917: Diff 34451!Dec 8 2023, 12:36 PM

atul added a child revision: D10274: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`.Dec 8 2023, 12:43 PM

atul mentioned this in D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.Dec 11 2023, 9:39 AM

Don't need this after my proposal to fix types in D10235

This revision now requires changes to proceed.Dec 11 2023, 11:05 AM

No longer needed.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

user-selectors.js

25 lines

Diff 34451

View Options

lib/selectors/user-selectors.js

[lib] Introduce `getRelativeMemberInfos` which helps narrow `[Legacy]RawThreadInfos`AbandonedPublicActions