[lib] Introduce `getRelativeMemberInfos` which helps narrow `[Legacy]RawThreadInfos`
AbandonedPublic
Actions

Authored by atul on Dec 8 2023, 12:25 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Summary

This helper function really just wraps getMinimallyEncodedRelativeMemberInfos and getLegacyRelativeMemberInfos and helps narrow arg/return types. More in-depth discussion in D10235 when those utilities were introduced.

Depends on D10271

Test Plan

CI/flow/etc.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 8 2023, 12:25 PM

atul published this revision for review.Dec 8 2023, 12:26 PM

Harbormaster failed remote builds in B24917: Diff 34451!Dec 8 2023, 12:36 PM

atul added a child revision: D10274: [lib] Add branching to `reduceThreadInfos` to accomodate `RawThreadInfos`.Dec 8 2023, 12:43 PM

atul mentioned this in D10235: [lib] Update `getRelativeMemberInfos` to handle both `MinimallyEncoded` and `Legacy` variants.Dec 11 2023, 9:39 AM

Don't need this after my proposal to fix types in D10235

This revision now requires changes to proceed.Dec 11 2023, 11:05 AM

No longer needed.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

user-selectors.js

25 lines

Diff 34451

View Options

lib/selectors/user-selectors.js

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines	if [[ "$http_code" -ne 200 ]]; then
echo "Stopping primary and secondary nodes was successful. Continuing with migration."		echo "Stopping primary and secondary nodes was successful. Continuing with migration."
break		break
fi		fi

total_elapsed_time=$(( total_elapsed_time + retry_interval ))		total_elapsed_time=$(( total_elapsed_time + retry_interval ))
sleep $retry_interval		sleep $retry_interval
done		done


echo "Applying terraform changes"		echo "Applying terraform changes"
terraform apply -auto-approve		terraform apply -auto-approve

		echo "Redisabling general lb traffic"
		disable_general_lb_traffic

echo "Redeploying primary service in $cluster_name"		echo "Redeploying primary service in $cluster_name"
aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null		aws ecs update-service --cluster "$cluster_name" --service "$primary_service_name" --force-new-deployment --desired-count 1 > /dev/null

echo "Waiting for health check at $health_check_domain to return status 200 OK"		echo "Waiting for health check at $health_check_domain to return status 200 OK"
check_health		check_health

		echo "Primary node successfully running. Re-enabling public access to load balancer"
		enable_lb_traffic

echo "Setting desired count of secondary service to $num_desired_secondary_nodes".		echo "Setting desired count of secondary service to $num_desired_secondary_nodes".
aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null		aws ecs update-service --cluster "$cluster_name" --service "$secondary_service_name" --desired-count "$num_desired_secondary_nodes" --force-new-deployment > /dev/null

echo "Successfully ran migration"		echo "Successfully ran migration"

[lib] Introduce `getRelativeMemberInfos` which helps narrow `[Legacy]RawThreadInfos`AbandonedPublicActions