Page MenuHomePhabricator
Differential D10397

[identity] Add function to remove device from list
ClosedPublic
Actions

Authored by bartek on Dec 19 2023, 4:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 11:44 PM
Unknown Object (File)
Oct 18 2024, 4:14 AM
Unknown Object (File)
Oct 18 2024, 4:14 AM
Unknown Object (File)
Oct 18 2024, 4:14 AM
Unknown Object (File)
Oct 18 2024, 4:14 AM
Unknown Object (File)
Oct 18 2024, 4:14 AM
Unknown Object (File)
Oct 18 2024, 4:14 AM
Unknown Object (File)
Oct 7 2024, 12:08 AM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
Commits
rCOMM7303098d4bda: [identity] Add function to remove device from list
Summary

Similiar to D10220 but for removing a device from the list.

Depends on D10304

Test Plan

Repeated test plan from D10220 then called this function and verified a new list was generated without the device.
Called the function twice - got DeviceNotFound error during second call, as expected.
Calling Logout RPC has the same effect.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Dec 19 2023, 4:49 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 19 2023, 4:49 AM
bartek added a child revision: D10398: [identity] Store device code version and login date.Dec 19 2023, 4:52 AM
Harbormaster completed remote builds in B25209: Diff 34827.Dec 19 2023, 5:13 AM
bartek published this revision for review.Dec 19 2023, 6:27 AM
bartek added a parent revision: D10423: [identity] Fix log_out_user DDB expression error.Dec 21 2023, 3:15 AM
bartek updated this revision to Diff 34903.Dec 21 2023, 3:15 AM

Rebase on fix

Harbormaster completed remote builds in B25270: Diff 34903.Dec 21 2023, 4:36 AM
varun accepted this revision.Jan 10 2024, 1:30 PM
varun added inline comments.
services/identity/src/database/device_list.rs
689

i think you forgot to update this comment after copying and pasting

This revision is now accepted and ready to land.Jan 10 2024, 1:30 PM
bartek updated this revision to Diff 35544.Jan 11 2024, 9:04 AM

Fix comment

Harbormaster completed remote builds in B25703: Diff 35544.Jan 11 2024, 9:30 AM
Closed by commit rCOMM7303098d4bda: [identity] Add function to remove device from list (authored by bartek). · Explain WhyJan 15 2024, 6:53 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM7303098d4bda: [identity] Add function to remove device from list.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
3 lines
database/
48 lines
1 line

Diff 34903

View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...
View Options

services/identity/src/error.rs

Loading...