Paths

Table of Contentst

-
services/identity/src/
-
identity/
-
src/
-
database.rs
-
database/
-
device_list.rs

[identity] Update login date for existing devices
ClosedPublic
Actions

Authored by bartek on Dec 19 2023, 4:54 AM.

Details

Reviewers

varun
michal

Commits

rCOMMc4f69edac3f2: [identity] Update login date for existing devices

Summary

A supplement for D10398 - when existing device calls login RPC again, the access token is minted again. We don't need to update the whole device list, but just update the login date so the primary device can be determined correctly.

Depends on D10398

Test Plan

Called login_password_user a few times and used awslocal dynamodb to verify that login date is updated correctly with each call.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 19 2023, 4:54 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 19 2023, 4:54 AM

bartek added a child revision: D10400: [identity] Create function to determine primary device.Dec 19 2023, 4:57 AM

Harbormaster failed remote builds in B25211: Diff 34829!Dec 19 2023, 5:47 AM

bartek published this revision for review.Dec 19 2023, 6:31 AM

varun accepted this revision.Jan 10 2024, 2:05 PM

This revision is now accepted and ready to land.Jan 10 2024, 2:05 PM

This revision was landed with ongoing or failed builds.Jan 15 2024, 6:53 AM

Closed by commit rCOMMc4f69edac3f2: [identity] Update login date for existing devices (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc4f69edac3f2: [identity] Update login date for existing devices.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

26 lines

database/

device_list.rs

34 lines

Diff 34829

View Options

services/identity/src/database.rs

	// @flow			// @flow

	import invariant from 'invariant';			import invariant from 'invariant';
	import * as React from 'react';			import * as React from 'react';

	import {			import {
	updateRelationships as serverUpdateRelationships,			updateRelationships as serverUpdateRelationships,
	updateRelationshipsActionTypes,			updateRelationshipsActionTypes,
	} from '../actions/relationship-actions.js';			} from '../actions/relationship-actions.js';
	import { getSingleOtherUser } from '../shared/thread-utils.js';			import { getSingleOtherUser } from '../shared/thread-utils.js';
	import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';			import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
	import {			import {
	type RelationshipAction,
	relationshipActions,			relationshipActions,
				type TraditionalRelationshipAction,
	} from '../types/relationship-types.js';			} from '../types/relationship-types.js';
	import type { UserInfo } from '../types/user-types.js';			import type { UserInfo } from '../types/user-types.js';
	import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';			import { useLegacyAshoatKeyserverCall } from '../utils/action-utils.js';
	import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';			import { useDispatchActionPromise } from '../utils/redux-promise-utils.js';
	import { useSelector } from '../utils/redux-utils.js';			import { useSelector } from '../utils/redux-utils.js';

	type RelationshipCallbacks = {			type RelationshipCallbacks = {
	+blockUser: () => void,			+blockUser: () => void,
	▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
	function useRelationshipCallbacks(			function useRelationshipCallbacks(
	otherUserID?: string,			otherUserID?: string,
	onErrorCallback?: () => void,			onErrorCallback?: () => void,
	): RelationshipCallbacks {			): RelationshipCallbacks {
	const callUpdateRelationships = useLegacyAshoatKeyserverCall(			const callUpdateRelationships = useLegacyAshoatKeyserverCall(
	serverUpdateRelationships,			serverUpdateRelationships,
	);			);
	const updateRelationship = React.useCallback(			const updateRelationship = React.useCallback(
	async (action: RelationshipAction) => {			async (action: TraditionalRelationshipAction) => {
	try {			try {
	invariant(otherUserID, 'Other user info id should be present');			invariant(otherUserID, 'Other user info id should be present');
	return await callUpdateRelationships({			return await callUpdateRelationships({
	action,			action,
	userIDs: [otherUserID],			userIDs: [otherUserID],
	});			});
	} catch (e) {			} catch (e) {
	onErrorCallback?.();			onErrorCallback?.();
	throw e;			throw e;
	}			}
	},			},
	[callUpdateRelationships, onErrorCallback, otherUserID],			[callUpdateRelationships, onErrorCallback, otherUserID],
	);			);

	const dispatchActionPromise = useDispatchActionPromise();			const dispatchActionPromise = useDispatchActionPromise();
	const onButtonPress = React.useCallback(			const onButtonPress = React.useCallback(
	(action: RelationshipAction) => {			(action: TraditionalRelationshipAction) => {
	void dispatchActionPromise(			void dispatchActionPromise(
	updateRelationshipsActionTypes,			updateRelationshipsActionTypes,
	updateRelationship(action),			updateRelationship(action),
	);			);
	},			},
	[dispatchActionPromise, updateRelationship],			[dispatchActionPromise, updateRelationship],
	);			);

	Show All 29 Lines