Page MenuHomePhabricator

[lib] Remove usage of `memberHasAdminPowers` in `useThreadSearchIndex`
ClosedPublic

Authored by atul on Mar 7 2024, 9:32 AM.
Tags
None
Referenced Files
F3342769: D11276.diff
Fri, Nov 22, 2:02 AM
Unknown Object (File)
Wed, Nov 20, 5:44 PM
Unknown Object (File)
Thu, Nov 7, 2:38 AM
Unknown Object (File)
Oct 15 2024, 8:04 PM
Unknown Object (File)
Oct 15 2024, 8:04 PM
Unknown Object (File)
Oct 15 2024, 8:04 PM
Unknown Object (File)
Oct 15 2024, 8:04 PM
Unknown Object (File)
Oct 15 2024, 8:04 PM
Subscribers

Details

Summary

As part of https://linear.app/comm/issue/ENG-6933/update-memberhasadminpower-logic-to-rely-on-specialrole-field, we're going to update memberHasAdminPowers so it determines whether a member is an admin not based on derived permissions, but whether they have an admin role in the community thread.

This will require us to change the signature of memberHasAdminPowers to include additional info (eg ThreadInfo). Before making that change, I wanted to go through all of the usages of memberHasAdminPowers to see how things would need to change at the callsite.

With useThreadSearchIndex, it was more efficient to calculate a map inline of communityThreadID -> memberID -> RoleInfo once and query that multidimensional dictionary rather than call a modified memberHasAdminPowers with communityThreadInfo and threadInfo.


Depends on D11263

Test Plan
  1. Able to log that the dictionary was constructed properly:
  1. Able to log that the computed isAdmin values were as expected:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage