Page MenuHomePhabricator
Differential D12853

[native] introduce message searching to `CommCoreModule`
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 3:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 1:30 AM
Unknown Object (File)
Tue, Mar 11, 4:03 PM
Unknown Object (File)
Feb 21 2025, 3:33 AM
Unknown Object (File)
Feb 21 2025, 3:33 AM
Unknown Object (File)
Feb 21 2025, 3:32 AM
Unknown Object (File)
Feb 21 2025, 3:32 AM
Unknown Object (File)
Jan 21 2025, 11:20 PM
Unknown Object (File)
Jan 21 2025, 10:05 PM
View All 70 Files
Subscribers
ashoat
inka

Details

Reviewers
tomek
inka
Commits
rCOMM12032bbfe1af: [native] introduce message searching to `CommCoreModule`
Summary

The code on native to interface with search API using JSI.

Depends on D12852

Test Plan

Tested later in the stack by @inka.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 23 2024, 3:09 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 3:09 AM
kamil added a child revision: D12854: [lib] introduce message searching to `SQLiteAPI`.Jul 23 2024, 3:10 AM
Harbormaster completed remote builds in B30599: Diff 42673.Jul 23 2024, 3:48 AM
kamil published this revision for review.Jul 23 2024, 5:04 AM
tomek accepted this revision.Jul 23 2024, 6:35 AM
tomek added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2700 ↗(On Diff #42673)

In some places, we're using a different syntax auto queryStr{query.utf8(rt)}. Which of them is the good practice?

native/schema/CommCoreModuleSchema.js
177 ↗(On Diff #42673)

T[] syntax is discouraged and might be deprecated in the future https://flow.org/en/docs/types/arrays/#toc-array-type-shorthand-syntax

This revision is now accepted and ready to land.Jul 23 2024, 6:35 AM
kamil added inline comments.Jul 23 2024, 8:05 AM
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2700 ↗(On Diff #42673)

I am not sure, I think it's better to stick to explicit types unless auto really makes sense, e.g. the return type of a function might be changed later with something compatible or when the type is already easily readable from the right side of the assignment. In other cases, I think it decreases readability.

native/schema/CommCoreModuleSchema.js
177 ↗(On Diff #42673)

going to add another diff and fix them all

Closed by commit rCOMM12032bbfe1af: [native] introduce message searching to `CommCoreModule` (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM12032bbfe1af: [native] introduce message searching to `CommCoreModule`.
kamil mentioned this in D12860: [CommCoreModule] remove `T[]` syntax.Jul 23 2024, 8:22 AM
kamil mentioned this in rCOMMf9ee4c4783ab: [CommCoreModule] remove `T[]` syntax.Jul 25 2024, 3:33 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
6 lines
55 lines
_generated/
schema/
6 lines

Diff 42709

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

native/schema/CommCoreModuleSchema.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;