The code on native to interface with search API using JSI.
Depends on D12852
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- cpp-search-2
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 2700 | In some places, we're using a different syntax auto queryStr{query.utf8(rt)}. Which of them is the good practice? | |
| native/schema/CommCoreModuleSchema.js | ||
| 177 | T[] syntax is discouraged and might be deprecated in the future https://flow.org/en/docs/types/arrays/#toc-array-type-shorthand-syntax | |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 2700 | I am not sure, I think it's better to stick to explicit types unless auto really makes sense, e.g. the return type of a function might be changed later with something compatible or when the type is already easily readable from the right side of the assignment. In other cases, I think it decreases readability. | |
| native/schema/CommCoreModuleSchema.js | ||
| 177 | going to add another diff and fix them all | |