Paths

Table of Contentst

-
keyserver/src/creators/
-
src/
-
creators/
-
message-creator.js
-
lib/
-
push/
-
send-utils.js
-
utils.js
-
shared/messages/
-
messages/
-
change-role-message-spec.js
-
change-settings-message-spec.js
-
create-entry-message-spec.js
-
create-sidebar-message-spec.js
-
create-sub-thread-message-spec.js
-
create-thread-message-spec.js
-
delete-entry-message-spec.js
-
edit-entry-message-spec.js
-
message-spec.js
-
multimedia-message-spec.js
-
reaction-message-spec.js
-
restore-entry-message-spec.js
-
sidebar-source-message-spec.js
-
text-message-spec.js
-
unsupported-message-spec.js
-
update-relationship-message-spec.js
-
native/types/
-
types/
-
message-types-validator.js

[lib][keyserver][native] Renames to prepare for some robotext not setting thread to unread
ClosedPublic
Actions

Authored by ashoat on Feb 11 2025, 12:11 AM.

Details

Reviewers

tomek
angelika

Commits

rCOMMb8c118d45e72: [lib][keyserver][native] Renames to prepare for some robotext not setting…

Summary

generatesNotifs will govern unread status going forward, so this diff renames it to getMessageNotifyType, and adds some new possible return values.

The reason that we're using a single spec function for both is described on Linear here.

Depends on D14333

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 11 2025, 12:11 AM

ashoat added a child revision: D14335: [keyserver][lib] Split generateNotifUserInfoPromise into two.

Harbormaster completed remote builds in B33450: Diff 46982.Feb 11 2025, 5:25 AM

ashoat requested review of this revision.Feb 11 2025, 5:25 AM

tomek accepted this revision.Feb 11 2025, 6:01 AM

tomek added inline comments.

lib/shared/messages/message-spec.js
70 ↗	(On Diff #46982)	Typo

This revision is now accepted and ready to land.Feb 11 2025, 6:01 AM

Fix typo

Harbormaster completed remote builds in B33472: Diff 47005.Feb 11 2025, 7:08 AM

Closed by commit rCOMMb8c118d45e72: [lib][keyserver][native] Renames to prepare for some robotext not setting… (authored by ashoat). · Explain WhyFeb 12 2025, 5:59 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb8c118d45e72: [lib][keyserver][native] Renames to prepare for some robotext not setting….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

message-creator.js

6 lines

lib/

push/

send-utils.js

6 lines

utils.js

14 lines

shared/

messages/

change-role-message-spec.js

4 lines

change-settings-message-spec.js

4 lines

create-entry-message-spec.js

4 lines

create-sidebar-message-spec.js

4 lines

create-sub-thread-message-spec.js

8 lines

create-thread-message-spec.js

4 lines

delete-entry-message-spec.js

4 lines

edit-entry-message-spec.js

4 lines

message-spec.js

16 lines

multimedia-message-spec.js

9 lines

reaction-message-spec.js

10 lines

restore-entry-message-spec.js

4 lines

sidebar-source-message-spec.js

4 lines

text-message-spec.js

4 lines

unsupported-message-spec.js

4 lines

update-relationship-message-spec.js

4 lines

native/

types/

message-types-validator.js

2 lines

Diff 47005

View Options

keyserver/src/creators/message-creator.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents

View Options

lib/push/send-utils.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents

View Options

lib/push/utils.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents

View Options

lib/shared/messages/change-role-message-spec.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents

View Options

lib/shared/messages/change-settings-message-spec.js

View Options

lib/shared/messages/create-entry-message-spec.js

View Options

lib/shared/messages/create-sidebar-message-spec.js

View Options

lib/shared/messages/create-sub-thread-message-spec.js

View Options

lib/shared/messages/create-thread-message-spec.js

View Options

lib/shared/messages/delete-entry-message-spec.js

View Options

lib/shared/messages/edit-entry-message-spec.js

View Options

lib/shared/messages/message-spec.js

View Options

lib/shared/messages/multimedia-message-spec.js

View Options

lib/shared/messages/reaction-message-spec.js

View Options

lib/shared/messages/restore-entry-message-spec.js

View Options

lib/shared/messages/sidebar-source-message-spec.js

View Options

lib/shared/messages/text-message-spec.js

View Options

lib/shared/messages/unsupported-message-spec.js

View Options

lib/shared/messages/update-relationship-message-spec.js

View Options

native/types/message-types-validator.js

[lib][keyserver][native] Renames to prepare for some robotext not setting thread to unreadClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47005

keyserver/src/creators/message-creator.js

lib/push/send-utils.js

lib/push/utils.js

lib/shared/messages/change-role-message-spec.js

lib/shared/messages/change-settings-message-spec.js

lib/shared/messages/create-entry-message-spec.js

lib/shared/messages/create-sidebar-message-spec.js

lib/shared/messages/create-sub-thread-message-spec.js

lib/shared/messages/create-thread-message-spec.js

lib/shared/messages/delete-entry-message-spec.js

lib/shared/messages/edit-entry-message-spec.js

lib/shared/messages/message-spec.js

lib/shared/messages/multimedia-message-spec.js

lib/shared/messages/reaction-message-spec.js

lib/shared/messages/restore-entry-message-spec.js

lib/shared/messages/sidebar-source-message-spec.js

lib/shared/messages/text-message-spec.js

lib/shared/messages/unsupported-message-spec.js

lib/shared/messages/update-relationship-message-spec.js

native/types/message-types-validator.js

[lib][keyserver][native] Renames to prepare for some robotext not setting thread to unread
ClosedPublic
Actions

Revision Contents
Changeset List