Page MenuHomePhabricator
Differential D14536

[native] Add delete message spec to the C++ layer
ClosedPublic
Actions

Authored by tomek on Thu, Apr 3, 8:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 11:29 AM
Unknown Object (File)
Thu, Apr 17, 9:44 PM
Unknown Object (File)
Thu, Apr 17, 1:57 AM
Unknown Object (File)
Tue, Apr 15, 5:26 AM
Unknown Object (File)
Mon, Apr 14, 3:16 AM
Unknown Object (File)
Fri, Apr 11, 5:47 PM
Unknown Object (File)
Thu, Apr 10, 6:40 PM
Unknown Object (File)
Thu, Apr 10, 3:33 AM
View All 24 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM2f8cdca9887d: [native] Add delete message spec to the C++ layer
Summary

Create C++ types for persisted delete messages.

https://linear.app/comm/issue/ENG-10325/create-a-new-message-type

Depends on D14535

Test Plan

Tested later in the stack by deleting a message in a thick threads, closing, and reopening the app - the message should be displayed as deleted.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Thu, Apr 3, 8:27 AM
Harbormaster completed remote builds in B33893: Diff 47643.Thu, Apr 3, 8:45 AM
tomek requested review of this revision.Thu, Apr 3, 8:45 AM
ashoat accepted this revision.Thu, Apr 3, 8:49 PM

Do we need to do anything for it to be included in the Android build, eg. update some CMakeLists.txt file?

This revision is now accepted and ready to land.Thu, Apr 3, 8:49 PM
tomek added a child revision: D14539: [lib] Create a DM op spec for deleting messages operation.Fri, Apr 4, 3:06 AM
tomek added a comment.Wed, Apr 9, 9:23 AM
In D14536#403268, @ashoat wrote:

Do we need to do anything for it to be included in the Android build, eg. update some CMakeLists.txt file?

We don't. I checked if yarn react-native run-android works. Also searched for the headers of other specs - and they don't appear in Android specific files. I would also expect the CI to fail.

Closed by commit rCOMM2f8cdca9887d: [native] Add delete message spec to the C++ layer (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM2f8cdca9887d: [native] Add delete message spec to the C++ layer.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
PersistentStorageUtilities/
MessageOperationsUtilities/
3 lines
MessageSpecs/
14 lines
1 line
ios/
Comm.xcodeproj/
2 lines

Diff 47643

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/DeleteMessageSpec.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageTypeEnum.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...