Page MenuHomePhabricator
Differential D14545

[native] Display a deleted message on native
ClosedPublic
Actions

Authored by tomek on Fri, Apr 4, 4:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 12:07 PM
Unknown Object (File)
Mon, Apr 21, 11:07 AM
Unknown Object (File)
Sat, Apr 19, 10:04 AM
Unknown Object (File)
Fri, Apr 18, 10:57 AM
Unknown Object (File)
Thu, Apr 17, 2:51 PM
Unknown Object (File)
Thu, Apr 17, 11:05 AM
Unknown Object (File)
Wed, Apr 16, 10:31 AM
Unknown Object (File)
Mon, Apr 14, 10:53 PM
View All 30 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM741247862ce6: [native] Display a deleted message on native
Summary

The message looks similar to the web one. Tried to find a color that looks ok for both senders and is distinctive enough.

https://linear.app/comm/issue/ENG-10346/replace-deleted-messages-by-a-text-message

native-delete-dark-2.png (339×406 px, 24 KB)

native-delete-light-2.png (324×402 px, 22 KB)

Depends on D14544

Test Plan

Checked if a message looks ok in both light and dark modes.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Fri, Apr 4, 4:38 AM
tomek edited the summary of this revision. (Show Details)Fri, Apr 4, 4:39 AM
tomek added a child revision: D14546: [native] Update message height measurement logic to handle deleted messages.Fri, Apr 4, 4:52 AM
Harbormaster completed remote builds in B33905: Diff 47657.Fri, Apr 4, 4:57 AM
tomek requested review of this revision.Fri, Apr 4, 4:57 AM
ashoat requested changes to this revision.Fri, Apr 4, 8:49 AM

Same feedback as in D14544

This revision now requires changes to proceed.Fri, Apr 4, 8:49 AM
tomek updated this revision to Diff 47725.Wed, Apr 9, 10:25 AM

Avoid using markdown. Update the design.

tomek edited the summary of this revision. (Show Details)Wed, Apr 9, 10:25 AM
Harbormaster completed remote builds in B33943: Diff 47725.Wed, Apr 9, 10:43 AM
ashoat accepted this revision.Wed, Apr 9, 8:05 PM
This revision is now accepted and ready to land.Wed, Apr 9, 8:05 PM
Closed by commit rCOMM741247862ce6: [native] Display a deleted message on native (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM741247862ce6: [native] Display a deleted message on native.

Revision Contents
Changeset List

PathSize
native/
chat/
76 lines
5 lines
themes/
4 lines

Diff 47657

View Options

native/chat/deleted-message.react.js

Loading...
View Options

native/chat/message.react.js

Loading...
View Options

native/themes/colors.js

Loading...