Paths

Table of Contentst

Differential D14787

[lib][native][web] implement getting `synced_metadata` entry
ClosedPublic
Actions

Authored by kamil on May 30 2025, 9:17 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM7e1c84c9dde5: [lib][native][web] implement getting `synced_metadata` entry

Summary

Part of ENG-7014

We need to query the store version that will be stored in synced_metadata. This will have three purposes:

Address https://phab.comm.dev/D14780#inline-81137
Being able to detect when backup is newer than an app and abort backup restore
Store a backup store version somewhere and trigger backup restore after the user updates the app
In the future, reading user-specific data we store in synced_metadata (e.g. currentUserInfo)

Depends on D14774

Test Plan

Tests, call getSyncedMetadata from SQLiteAPI

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 30 2025, 9:17 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 30 2025, 9:17 AM

kamil added a child revision: D14788: [web] refactor code to get query executor.May 30 2025, 9:31 AM

CI

Harbormaster failed remote builds in B34320: Diff 48343!May 30 2025, 10:08 AM

Harbormaster completed remote builds in B34322: Diff 48345.May 30 2025, 10:27 AM

kamil published this revision for review.May 30 2025, 12:38 PM

kamil edited the summary of this revision. (Show Details)

bartek accepted this revision.Jun 2 2025, 9:01 AM

This revision is now accepted and ready to land.Jun 2 2025, 9:01 AM

Closed by commit rCOMM7e1c84c9dde5: [lib][native][web] implement getting `synced_metadata` entry. · Explain WhyJun 2 2025, 10:40 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM7e1c84c9dde5: [lib][native][web] implement getting `synced_metadata` entry.

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

4 lines

utils/

__mocks__/

1 line

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

2 lines

SQLiteQueryExecutor.h

2 lines

SQLiteQueryExecutor.cpp

16 lines

NativeModules/

CommCoreModule.h

4 lines

CommCoreModule.cpp

37 lines

_generated/

commJSI-generated.cpp

database/

1 line

schema/

CommCoreModuleSchema.js

2 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

3 lines

database/

13 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

synced-metadata-queries.test.js

7 lines

types/

sqlite-query-executor.js

1 line

worker/

shared-worker.js

22 lines

types/

worker-types.js

19 lines

Diff 48381

lib/types/sqlite-types.js

Loading...

lib/utils/mocks/config.js

Loading...

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/database/sqlite-api.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...

web/database/sqlite-api.js

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/queries/synced-metadata-queries.test.js

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...

web/shared-worker/worker/shared-worker.js

Loading...

web/types/worker-types.js

Loading...