[SQLite] make `connectionManager` private and use abstract class
ClosedPublic
Actions

Authored by kamil on May 21 2025, 9:58 AM.

Details

Reviewers

bartek
tomek
angelika

Commits

rCOMM191f31a3d54d: [SQLite] make `connectionManager` private and use abstract class

Summary

Implemented as part of ENG-10603

Another follow-up to D14736.

Finally, we don't have any platform-specific code for SQLiteQueryExecutor.

If the SQLiteConnectionManager pointer is not passed to the constructor, we create WebSQLiteConnectionManager because we don't have the keys to call NativeSQLiteConnectionManager.

I am also considering renaming:
NativeSQLiteConnectionManager -> EncryptedSQLiteConnectionManager
WebSQLiteConnectionManager -> NotEncryptedConnectionManager

This perhaps makes it even more readable and more platform-independent.

Depends on D14738

Test Plan

Build, kill and open app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 21 2025, 9:58 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2025, 9:58 AM

Harbormaster completed remote builds in B34221: Diff 48156.May 21 2025, 10:18 AM

kamil edited the summary of this revision. (Show Details)May 21 2025, 3:06 PM

bartek mentioned this in D14720: [SQLite] temporary make `SQLiteQueryExecutor` methods and fields public.May 22 2025, 7:39 AM

kamil published this revision for review.May 22 2025, 8:05 AM

I also did some end-to-end testing of this stack as part of ENG-8337#comment-2a948044

kamil added a child revision: D14741: [SQLite] extract method to copy content between databases.May 22 2025, 9:21 AM

I am also considering renaming:
NativeSQLiteConnectionManager -> EncryptedSQLiteConnectionManager
WebSQLiteConnectionManager -> NotEncryptedConnectionManager

This perhaps makes it even more readable and more platform-independent.

Arguably, it might be a good idea, but for now, I'd leave the naming platform-based

This revision is now accepted and ready to land.May 26 2025, 9:10 AM

rebase before landing

Harbormaster completed remote builds in B34264: Diff 48228.May 26 2025, 12:07 PM

I did some more testing of this to make sure nothing is broken, testing most important app features on both iOS and Android (physical devices) along with web

Closed by commit rCOMM191f31a3d54d: [SQLite] make `connectionManager` private and use abstract class. · Explain WhyMay 26 2025, 12:11 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM191f31a3d54d: [SQLite] make `connectionManager` private and use abstract class.

bartek mentioned this in D14748: [web][native] create two `SQLiteQueryExecutor` instances.May 27 2025, 8:49 AM