Differential D14718 Authored by kamil on May 20 2025, 11:22 AM.
Details Summary Implemented as part of ENG-10603 We need to move it higher to be able to create multiple SQLiteQueryExecutor's. Logic should remain unchanged; later in the stack, there are more improvements to avoid having static props and to remove SQLiteQueryExecutor::initialize. Additionally, this code is not used on the web, so there is no need to keep it in a shared place initializeSQLiteQueryExecutorProperties implementation is mostly a copy-paste of old SQLiteQueryExecutor::initialize. Depends on D14717 Test Plan Build the app and check that database is still there and can be used without logging out user. Then logout to check if generation still works.
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added a subscriber: ashoat. · View Herald TranscriptMay 20 2025, 11:22 AM2025-05-20 11:22:09 (UTC+0) kamil edited the summary of this revision. (Show Details)May 20 2025, 11:22 AM2025-05-20 11:22:42 (UTC+0) kamil added a child revision: D14719: [SQLite] remove old architecture comments.May 20 2025, 11:28 AM2025-05-20 11:28:18 (UTC+0) Harbormaster completed remote builds in B34200: Diff 48131.May 20 2025, 12:01 PM2025-05-20 12:01:51 (UTC+0) kamil edited the summary of this revision. (Show Details)May 20 2025, 2:25 PM2025-05-20 14:25:01 (UTC+0) Comment Actions This slightly affects ENG-10519 but makes it easier. I'd still decouple plain key generation from storing it in SecureStore, but it makes more sense for me to do it when working on rekeying This revision is now accepted and ready to land.May 22 2025, 7:36 AM2025-05-22 07:36:36 (UTC+0) Closed by commit rCOMM5f391d4dc9b0: [SQLite] move key generation to `DatabaseManager`. · Explain WhyMay 26 2025, 12:11 PM2025-05-26 12:11:05 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 48236 |