Paths

Table of Contentst

Differential D14791

[lib] checking database and store version before restoring
ClosedPublic
Actions

Authored by kamil on May 30 2025, 12:04 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM7da087c46833: [lib] checking database and store version before restoring

Summary

Part of ENG-7014.

Depends on D14790

Test Plan

Tested all cases, DB and store versions equal, higher and lower

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 30 2025, 12:04 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 30 2025, 12:04 PM

kamil added a child revision: D14792: [lib][web][native] prompt the user that app is out-of-date when restoring.May 30 2025, 12:04 PM

fix spacing

kamil mentioned this in D14793: [native][web] deprecate `getSyncedDatabaseVersion`.May 30 2025, 12:15 PM

Harbormaster completed remote builds in B34328: Diff 48351.May 30 2025, 12:26 PM

Harbormaster completed remote builds in B34326: Diff 48349.May 30 2025, 12:33 PM

kamil published this revision for review.May 30 2025, 12:43 PM

kamil added inline comments.May 30 2025, 3:42 PM

lib/backup/use-user-data-restore.js
62 ↗	(On Diff #48351)	The results are `string`'s, I should definitely convert them to numbers before comparing
63–66 ↗	(On Diff #48351)	Actually, I think I should use `getConfig` here to avoid any race conditions

bartek accepted this revision.Jun 2 2025, 9:12 AM

bartek added inline comments.

lib/backup/use-user-data-restore.js
63–66 ↗	(On Diff #48351)	Agree with this

This revision is now accepted and ready to land.Jun 2 2025, 9:12 AM

kamil added a child revision: D14793: [native][web] deprecate `getSyncedDatabaseVersion`.Jun 2 2025, 9:33 AM

use getConfig

Harbormaster completed remote builds in B34336: Diff 48360.Jun 2 2025, 9:51 AM

Closed by commit rCOMM7da087c46833: [lib] checking database and store version before restoring. · Explain WhyJun 2 2025, 10:40 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM8df7ac3bd52b: [native][web] deprecate `getSyncedDatabaseVersion`.

kamil added a commit: rCOMM7da087c46833: [lib] checking database and store version before restoring.

kamil removed a child revision: D14792: [lib][web][native] prompt the user that app is out-of-date when restoring.Jun 2 2025, 10:53 AM

Revision Contents
Changeset List

Path

Size

lib/

backup/

use-user-data-restore.js

84 lines

Diff 48384

lib/backup/use-user-data-restore.js

Loading...