Differential D14717 Authored by kamil on May 20 2025, 11:16 AM.
Details Summary Implemented as part of ENG-10603 generateBackupDataKey was currently generating two keys, which is extremely misleading. In the next diffs, those methods are going to be moved to DatabaseManager, so first, a refactor is in place to avoid confusing reviewers. Added some comments to make it clear. Depends on D14716 Test Plan Build the app and check that database is still there and can be used without logging out user. Then logout to check if generation still works.
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added a subscriber: ashoat. · View Herald TranscriptMay 20 2025, 11:16 AM2025-05-20 11:16:28 (UTC+0) Harbormaster completed remote builds in B34199: Diff 48130.May 20 2025, 11:50 AM2025-05-20 11:50:38 (UTC+0) This revision is now accepted and ready to land.May 21 2025, 8:19 AM2025-05-21 08:19:07 (UTC+0) Closed by commit rCOMM55d9dbdf6ca9: [SQLite] fix and improve `generateBackupDataKey`. · Explain WhyMay 26 2025, 12:11 PM2025-05-26 12:11:05 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 48235 |