Paths

Table of Contentst

[SQLite] extract code to validate main compaction
ClosedPublic
Actions

Authored by kamil on Jun 2 2025, 2:50 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM7cbe43af8526: [SQLite] extract code to validate main compaction

Summary

ENG-10786.

Extracting code, in the next diff, this is used elsewhere.

I also removed sqlite3 *db param from isDatabaseQueryable - I have no clue why it was needed, but after refactoring, there is no point to keep it.

Depends on D14793

Test Plan

Build app, build wasm

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 2 2025, 2:50 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 2 2025, 2:50 PM

Harbormaster completed remote builds in B34354: Diff 48405.Jun 2 2025, 3:08 PM

kamil edited the summary of this revision. (Show Details)Jun 3 2025, 8:49 AM

kamil added a child revision: D14802: [SQLite] update `restoredConnectionManager` to be `NativeSQLiteConnectionManager`.Jun 3 2025, 8:57 AM

kamil published this revision for review.Jun 3 2025, 10:02 AM

bartek accepted this revision.Jun 3 2025, 10:05 AM

This revision is now accepted and ready to land.Jun 3 2025, 10:05 AM

Closed by commit rCOMM7cbe43af8526: [SQLite] extract code to validate main compaction. · Explain WhyJun 4 2025, 2:08 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM7cbe43af8526: [SQLite] extract code to validate main compaction.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

5 lines

21 lines

1 line

11 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

Diff 48426

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

[SQLite] extract code to validate main compactionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48426

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteBackup.cpp

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp

web/shared-worker/_generated/comm_query_executor.wasm

[SQLite] extract code to validate main compaction
ClosedPublic
Actions

Revision Contents
Changeset List