[SQLite] temporary make `SQLiteQueryExecutor` methods and fields public
ClosedPublic
Actions

Authored by kamil on May 20 2025, 1:58 PM.

Details

Reviewers

bartek
tomek
angelika

Commits

rCOMMf3caa4b71bda: [SQLite] temporary make `SQLiteQueryExecutor` methods and fields public

Summary

Implemented as part of ENG-10603

NOTE: This is temporary to make refactoring possible, next diffs could either not build or have incorrect logic without this. Later in the stack, this is updated to be private again.

Depends on D14719

Test Plan

Build the app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 20 2025, 1:58 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 20 2025, 1:58 PM

kamil added a child revision: D14721: [SQLite] make functions in `EntityQueryHelpers.h` inline.May 20 2025, 1:59 PM

Harbormaster completed remote builds in B34202: Diff 48137.May 20 2025, 2:20 PM

kamil published this revision for review.May 20 2025, 3:58 PM

kamil mentioned this in D14736: [SQLite] make `getConnection` private.May 21 2025, 9:01 AM

This is temporary to make refactoring possible, next diffs could either not build or have incorrect logic without this. Later in the stack, this is updated to be private again.

The diffs are:

This revision is now accepted and ready to land.May 22 2025, 7:39 AM

Closed by commit rCOMMf3caa4b71bda: [SQLite] temporary make `SQLiteQueryExecutor` methods and fields public. · Explain WhyMay 26 2025, 12:11 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMf3caa4b71bda: [SQLite] temporary make `SQLiteQueryExecutor` methods and fields public.

kamil mentioned this in rCOMMdc90b3feacb3: [SQLite] make `getConnection` private.