Differential D14735 Authored by kamil on May 20 2025, 2:15 PM.
Details Summary Implemented as part of ENG-10603 This diff encapsulates the path and keys in the manager class and removes static props. This enhances code readability, and after this, we're able to create multiple SQLiteQueryExecutor. Only NativeSQLiteConnectionManager has keys because on the web we use a different encryption mechanism. Depends on D14734 Test Plan restore, login/logout, sending some messages, creating drafts and checking if those are persisted - did also some overall testing, even notifs
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added a subscriber: ashoat. · View Herald TranscriptMay 20 2025, 2:15 PM2025-05-20 14:15:44 (UTC+0) kamil edited the summary of this revision. (Show Details)May 20 2025, 3:54 PM2025-05-20 15:54:35 (UTC+0) kamil retitled this revision from [SQLite] move paths and keys to ConnectionManager to [SQLite] move database path and keys to `SQLiteConnectionManager` and derived classes. Harbormaster completed remote builds in B34217: Diff 48152.May 20 2025, 4:55 PM2025-05-20 16:55:06 (UTC+0) kamil edited the test plan for this revision. (Show Details)May 21 2025, 8:45 AM2025-05-21 08:45:09 (UTC+0) kamil added a child revision: D14736: [SQLite] make `getConnection` private.May 21 2025, 9:01 AM2025-05-21 09:01:59 (UTC+0)
This revision is now accepted and ready to land.May 23 2025, 11:58 AM2025-05-23 11:58:28 (UTC+0) Harbormaster completed remote builds in B34260: Diff 48224.May 26 2025, 11:21 AM2025-05-26 11:21:06 (UTC+0) Closed by commit rCOMM6dc7b3d63ff4: [SQLite] move database path and keys to `SQLiteConnectionManager` and derived…. · Explain WhyMay 26 2025, 12:11 PM2025-05-26 12:11:32 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 48253 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||