Differential D14738 Authored by kamil on May 21 2025, 9:44 AM.
Details Summary Implemented as part of ENG-10603 This is native-specific and should be placed in the shared SQLiteQueryExecutor. It should also be executed only once, as this is more of a connectionManager responsibility than SQLiteQueryExecutor—in the previous implementation, there was a bug; this code was executed as many times as many threads were using the database. Depends on D14737 Test Plan Flip the flag and check if logs are uploaded
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added a subscriber: ashoat. · View Herald TranscriptMay 21 2025, 9:44 AM2025-05-21 09:44:22 (UTC+0) Harbormaster completed remote builds in B34220: Diff 48155.May 21 2025, 10:05 AM2025-05-21 10:05:30 (UTC+0) bartek added inline comments.
This revision is now accepted and ready to land.May 23 2025, 12:02 PM2025-05-23 12:02:55 (UTC+0) Harbormaster completed remote builds in B34261: Diff 48225.May 26 2025, 11:37 AM2025-05-26 11:37:27 (UTC+0) Closed by commit rCOMMf3ad30bac80f: [SQLite] move starting log monitoring to `DatabaseManager`. · Explain WhyMay 26 2025, 12:11 PM2025-05-26 12:11:36 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 48256 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||