Details

Reviewers

bartek

Commits

rCOMMf35d63b7250b: [native][RN79][skip-ci] Add missing imports in cpp header files

Summary

https://linear.app/comm/issue/ENG-10286/migrate-jsi-related-stuff
Depends on D14967

Test Plan

Build and run the app

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 19 2025, 8:17 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 19 2025, 8:17 AM

angelika added a child revision: D14969: [native][RN79][skip-ci] Replace folly::trimWhitespace with StringUtils::trimWhitespace.Jul 19 2025, 8:19 AM

Harbormaster completed remote builds in B34616: Diff 48813.Jul 19 2025, 8:21 AM

Rebase

Harbormaster completed remote builds in B34820: Diff 49027.Jul 24 2025, 4:14 PM

angelika published this revision for review.Jul 25 2025, 9:03 AM

bartek accepted this revision.Jul 28 2025, 7:07 AM

This revision is now accepted and ready to land.Jul 28 2025, 7:07 AM

Rebase & review changes

Harbormaster completed remote builds in B35087: Diff 49338.Aug 9 2025, 12:14 PM

Rebase & review changes

Harbormaster completed remote builds in B35353: Diff 49642.Aug 21 2025, 12:35 PM

Closed by commit rCOMMf35d63b7250b: [native][RN79][skip-ci] Add missing imports in cpp header files. · Explain WhyAug 21 2025, 7:30 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMf35d63b7250b: [native][RN79][skip-ci] Add missing imports in cpp header files.

[native][RN79][skip-ci] Add missing imports in cpp header files
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 48813

native/cpp/CommonCpp/NativeModules/InternalModules/GlobalDBSingleton.h

native/cpp/CommonCpp/NativeModules/InternalModules/RustPromiseManager.h

[native][RN79][skip-ci] Add missing imports in cpp header filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48813

native/cpp/CommonCpp/NativeModules/InternalModules/GlobalDBSingleton.h

native/cpp/CommonCpp/NativeModules/InternalModules/RustPromiseManager.h

[native][RN79][skip-ci] Add missing imports in cpp header files
ClosedPublic
Actions

Revision Contents
Changeset List