https://linear.app/comm/issue/ENG-10284/migrate-expo-secure-store-related-code
The Kotlin code in securestore folder was mostly copied from expo-secure-store source code.
Depends on D15136
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/android/app/src/main/java/app/comm/android/fbjni/CommSecureStore.java | ||
|---|---|---|
| 64–65 ↗ | (On Diff #48823) | This part and runBlocking in setValueWithKey/getValueWithKey is tricky. Before we were calling getValueWithKeyAsync and according to the comment here the call resolved the promise before it returned. So that means it wasn't really async. I changed the name of the functions to reflect this and added runBlocking. Without it, the promise wasn't resolved before returning and it resulted in crashing the app. |
Comment Actions
Two notes here:
- I see the patch from D14979 is applied here 👍
- I'm not sure if we should somehow indicate credits for the original expo-secure-store. I suppose a comment at the top of the files explaining that this code originates from expo-secure-store@12.x (or the current version) and why we copied it would be sufficient.
| native/android/app/src/main/java/app/comm/android/fbjni/CommSecureStore.java | ||
|---|---|---|
| 64–65 ↗ | (On Diff #48823) | Nice find! |
Comment Actions
Not sure, maybe we should do a bit more. If it is third-party code, we should also include its license.