Differential D14976

[native][RN79][skip-ci] Update native files on iOS
ClosedPublic
Actions

Authored by angelika on Jul 21 2025, 12:19 PM.

Tags

None

Referenced Files

	F32161538: D14976.1765043489.diff
	Fri, Dec 5, 5:51 PM

Subscribers

Details

Reviewers

Commits

rCOMMbfacd8ec9949: [native][RN79][skip-ci] Update native files on iOS

Summary

https://linear.app/comm/issue/ENG-10275/apply-the-diff-from-react-native-upgrade-helper

Applied the diff from expo's upgrade helper to ios native files.

Depends on D14975

Test Plan

https://linear.app/comm/issue/ENG-10985/final-testing

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 21 2025, 12:19 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2025, 12:20 PM

Harbormaster completed remote builds in B34627: Diff 48826.Jul 21 2025, 12:23 PM

angelika added a child revision: D14977: [native][RN79][skip-ci] Migrate AppDelegate to Swift.Jul 21 2025, 12:26 PM

Rebase

Harbormaster completed remote builds in B34827: Diff 49034.Jul 24 2025, 4:17 PM

angelika published this revision for review.Jul 25 2025, 9:09 AM

bartek accepted this revision.Jul 28 2025, 7:17 AM

bartek added inline comments.

native/ios/Comm.xcodeproj/project.pbxproj
2039 ↗	(On Diff #49034)	I'm excited about that! I was missing some cpp20 stl APIs

This revision is now accepted and ready to land.Jul 28 2025, 7:17 AM

ashoat added inline comments.Jul 29 2025, 12:39 PM

native/ios/Comm/Info.release.plist
142 ↗	(On Diff #49034)	What's the significance of this change?

ashoat added inline comments.Jul 29 2025, 12:40 PM

native/ios/Comm.xcodeproj/project.pbxproj
2039 ↗	(On Diff #49034)	If it's done for Android too we can finally close this one: https://linear.app/comm/issue/ENG-1585/use-c20-on-native-for-coroutine-support

ashoat mentioned this in D15161: [web][native] handle QueuedDMOperations for the backup.Jul 29 2025, 1:32 PM

Rebase & review changes

Harbormaster completed remote builds in B35094: Diff 49345.Aug 9 2025, 12:15 PM

angelika added inline comments.Aug 20 2025, 8:36 PM

native/ios/Comm.xcodeproj/project.pbxproj
2039 ↗	(On Diff #49034)	It's not done for android, but it should be just a matter of changing this setting: https://github.com/CommE2E/comm/blob/master/native/android/app/CMakeLists.txt#L5
native/ios/Comm/Info.release.plist
142 ↗	(On Diff #49034)	The change was in the upgrade helper. According to Apple's docs this option will cause App Store to prevent users from installing the app on devices not supporting arm64 arch. It shouldn't change anything though, since iphones as old as iPhone 6 support arm64 arch list

Rebase & review changes

Harbormaster completed remote builds in B35360: Diff 49649.Aug 21 2025, 12:36 PM

Closed by commit rCOMMbfacd8ec9949: [native][RN79][skip-ci] Update native files on iOS. · Explain WhyAug 21 2025, 7:31 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMbfacd8ec9949: [native][RN79][skip-ci] Update native files on iOS.

Revision Contents
Changeset List

Path

Size

native/

12 lines

ios/

Comm.xcodeproj/

project.pbxproj

163 lines

Comm/

Info.debug.plist

18 lines

Info.release.plist

6 lines

102 lines

2973 lines

Podfile.properties.json

4 lines

PrivacyInfo.xcprivacy

32 lines

Diff 49345

native/Gemfile

Loading...

native/ios/Comm.xcodeproj/project.pbxproj

Loading...

native/ios/Comm/Info.debug.plist

Loading...

native/ios/Comm/Info.release.plist

Loading...

native/ios/Podfile

Loading...

native/ios/Podfile.lock

Loading...

native/ios/Podfile.properties.json

Loading...

native/ios/PrivacyInfo.xcprivacy

Loading...