Paths

Table of Contentst

Differential D14982

[native][RN79][skip-ci] Migrate SecondaryDeviceQRCodeScanner to react-native-vision-camera
ClosedPublic
Actions

Authored by angelika on Jul 21 2025, 12:49 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMf1a79b9a533e: [native][RN79][skip-ci] Migrate SecondaryDeviceQRCodeScanner to react-native…

Summary

https://linear.app/comm/issue/ENG-10254/migrate-react-native-camera-to-react-native-vision-camera

Depends on D14981

Test Plan

Add a linked device with qr code scanner.
Do this with and without camera permissions, make sure the permissions are handled correctly.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 21 2025, 12:49 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2025, 12:49 PM

Harbormaster completed remote builds in B34633: Diff 48832.Jul 21 2025, 12:53 PM

angelika added a child revision: D14987: [native][RN79][skip-ci] Migrate CameraModal to react-native-vision-camera.Jul 21 2025, 8:07 PM

bartek added inline comments.Jul 22 2025, 8:01 AM

native/account/qr-auth/secondary-device-qr-code-scanner.react.js
97–101 ↗	(On Diff #48832)	Why is this and the `scanned` state no longer needed?
150 ↗	(On Diff #48832)	If device is unavailable, we could add an `else` clause and display sth like `<Text>No camera is available on your device</Text>`

Rebase

Harbormaster completed remote builds in B34833: Diff 49040.Jul 24 2025, 4:17 PM

Rebase & review changes

Harbormaster completed remote builds in B35100: Diff 49351.Aug 9 2025, 12:15 PM

angelika published this revision for review.Aug 9 2025, 12:19 PM

angelika added inline comments.

native/account/qr-auth/secondary-device-qr-code-scanner.react.js
97–101 ↗	(On Diff #48832)	It's not mentioned in the documentation and it was working without it, we're navigating to the next screen anyway after we scan the code. I brought it back, maybe there is some performance benefit.
150 ↗	(On Diff #48832)	Added

bartek accepted this revision.Aug 11 2025, 8:15 AM

This revision is now accepted and ready to land.Aug 11 2025, 8:15 AM

Rebase & review changes

Harbormaster completed remote builds in B35366: Diff 49655.Aug 21 2025, 12:34 PM

Closed by commit rCOMMf1a79b9a533e: [native][RN79][skip-ci] Migrate SecondaryDeviceQRCodeScanner to react-native…. · Explain WhyAug 21 2025, 7:31 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMf1a79b9a533e: [native][RN79][skip-ci] Migrate SecondaryDeviceQRCodeScanner to react-native….

Revision Contents
Changeset List

Path

Size

native/

account/

qr-auth/

secondary-device-qr-code-scanner.react.js

66 lines

Diff 49351

native/account/qr-auth/secondary-device-qr-code-scanner.react.js

Loading...