Paths

Table of Contentst

Differential D15095

[Flow262][skip-ci] Fix SET_TB_DEVICE_TOKEN_FAILED payload type
ClosedPublic
Actions

Authored by angelika on Jul 23 2025, 3:54 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMcedacad880ac: [Flow262][skip-ci] Fix SET_TB_DEVICE_TOKEN_FAILED payload type

Summary

https://linear.app/comm/issue/ENG-10205/update-flow-to-02691

Depends on D15094

Test Plan

Flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 23 2025, 3:54 PM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 23 2025, 3:54 PM

Harbormaster completed remote builds in B34752: Diff 48957.Jul 23 2025, 3:57 PM

angelika added a child revision: D15096: [Flow262][skip-ci] Fix resetUserSpecificState function.Jul 23 2025, 4:04 PM

Rebase

Harbormaster completed remote builds in B34938: Diff 49145.Jul 24 2025, 4:30 PM

angelika published this revision for review.Jul 25 2025, 9:56 AM

angelika added a reviewer: tomek.

tomek requested changes to this revision.Jul 31 2025, 3:25 PM

tomek added inline comments.

lib/types/redux-types.js
1563 ↗	(On Diff #49145)	All the other `_FAILED` actions have `Error` as the payload. Why do we need a string here? Is it due to a mistake at some place?

This revision now requires changes to proceed.Jul 31 2025, 3:25 PM

angelika added inline comments.Aug 1 2025, 6:47 AM

lib/types/redux-types.js
1563 ↗	(On Diff #49145)	According to this line it can be a string too and it's thrown here

tomek accepted this revision.Aug 4 2025, 1:33 PM

tomek added a subscriber: bartek.

tomek added inline comments.

lib/types/redux-types.js
1563 ↗	(On Diff #49145)	Ok, makes sense! It's good to update the JS types to reflect the actual options, but it looks like a mistake on our side. @bartek could you take a look? Maybe we should update our Rust code.

This revision is now accepted and ready to land.Aug 4 2025, 1:33 PM

bartek added inline comments.Aug 4 2025, 2:17 PM

lib/types/redux-types.js
1563 ↗	(On Diff #49145)	This looks unusual but seems alright. It's not Rust code, but client-side TB code, which rejects a promise with string payload

Rebase & review changes

Harbormaster completed remote builds in B35203: Diff 49454.Aug 9 2025, 12:33 PM

bartek mentioned this in D15188: [lib] implement sending Farcaster requests.Aug 12 2025, 7:53 AM

Rebase & review changes

Harbormaster completed remote builds in B35469: Diff 49758.Aug 21 2025, 12:56 PM

Closed by commit rCOMMcedacad880ac: [Flow262][skip-ci] Fix SET_TB_DEVICE_TOKEN_FAILED payload type. · Explain WhyAug 21 2025, 7:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMcedacad880ac: [Flow262][skip-ci] Fix SET_TB_DEVICE_TOKEN_FAILED payload type.

Revision Contents
Changeset List

Path

Size

lib/

types/

2 lines

Diff 49454

lib/types/redux-types.js

Loading...