https://linear.app/comm/issue/ENG-10741/clearabletextinputissue
updateTextFromOldInput was firing additional update which deleted the text in text input
Depends on D15120
Details
Details
Use text input a lot. Try editing, check if drafts work. Also:
- send a message
- type abc space
- verify text didn't disappear
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
There is more context on the linear issue: https://linear.app/comm/issue/ENG-10741/clearabletextinputissue
Farcaster has the same change. From the Ashoat's comment:
We also don't use the updateTextFromOldInput functionality on the iOS side that handles late onChangeText events from the old input by removing the already-sent message
It looks like there is an additional onChangeText event in more recent versions of react-native. There is a code that clears the text input when a message is sent and it triggered onChangeText and it triggered updateTextFromOldInput unnecessarily with empty text and it caused to delete what's already in the text input.