Paths

Table of Contentst

Differential D15126

[native][RN80][skip-ci] Remove enhanceMiddleware hack
ClosedPublic
Actions

Authored by angelika on Jul 24 2025, 8:42 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM771a7c98bb39: [native][RN80][skip-ci] Remove enhanceMiddleware hack

Summary

https://linear.app/comm/issue/ENG-10740/rethink-the-enhancemiddleware-hack

Tried deleting the hack and nothing broke. Also when logging req.url it was always starting with assets.

Depends on D15125

Test Plan

Build the app, verify images and fonts are there.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jul 24 2025, 8:42 AM

angelika held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2025, 8:42 AM

Harbormaster completed remote builds in B34785: Diff 48990.Jul 24 2025, 8:44 AM

angelika added a child revision: D15127: [native][RN80][skip-ci] Remove unecessary babel plugins.Jul 24 2025, 8:45 AM

Rebase

Harbormaster completed remote builds in B34969: Diff 49176.Jul 24 2025, 4:33 PM

angelika published this revision for review.Jul 25 2025, 10:07 AM

bartek accepted this revision.Jul 28 2025, 8:32 AM

This revision is now accepted and ready to land.Jul 28 2025, 8:32 AM

Tried deleting the hack and nothing broke.

Have you checked a diff where this hack was introduced and repeated a test plan from that diff? Please expand your test plan with these steps.

This revision now requires changes to proceed.Aug 5 2025, 10:34 AM

Rebase & review changes

Harbormaster completed remote builds in B35234: Diff 49485.Aug 9 2025, 12:38 PM

There is no diff for this, only commit: https://github.com/CommE2E/comm/commit/5758dfee1db5e78b084569531207d889465c8852
The commit message mentioned an issue with resolving images (back-button.png which is no longer in the repo) and in my test plan I've included a check if images are resolved.

Just to make sure: have you tested it on Android in dev mode, like the comment suggests?

This revision is now accepted and ready to land.Aug 11 2025, 3:27 PM

In D15126#417648, @tomek wrote:

Just to make sure: have you tested it on Android in dev mode, like the comment suggests?

Yes, I tested on Android dev mode with my physical device.

Rebase & review changes

Harbormaster completed remote builds in B35500: Diff 49789.Aug 21 2025, 1:00 PM

Closed by commit rCOMM771a7c98bb39: [native][RN80][skip-ci] Remove enhanceMiddleware hack. · Explain WhyAug 21 2025, 7:35 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM771a7c98bb39: [native][RN80][skip-ci] Remove enhanceMiddleware hack.

Revision Contents
Changeset List

Path

Size

native/

metro.config.js

6 lines

Diff 49485

native/metro.config.js

Loading...