Page MenuHomePhabricator

[Services] Update tunnelbroker Dockerfile & cmake
ClosedPublic

Authored by jon on Jul 28 2022, 6:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:27 PM
Unknown Object (File)
Sun, Oct 27, 6:16 AM
Unknown Object (File)
Sun, Oct 27, 6:16 AM
Unknown Object (File)
Sun, Oct 27, 6:16 AM
Unknown Object (File)
Sun, Oct 27, 6:16 AM
Unknown Object (File)
Sun, Oct 27, 6:16 AM
Unknown Object (File)
Sun, Oct 27, 6:16 AM
Unknown Object (File)
Sun, Oct 27, 6:16 AM

Details

Summary

Reflect the changes to installing
the dependencies versus just adding the source
directories

This breaks backup as the docker image isn't updated until D4494
This breaks blob as the docker image + cmake isn't updated until D4493

Test Plan

Docker workflow:

docker build . -f services/tunnelbroker/Dockerfile

Before this is merged, base-image will need to be updated to reference
new docker hub image

Nix worfklow

nix develop
cd services/tunnelbroker
mkdir build && cd build && cmake .. && make

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2022, 6:01 PM
Harbormaster failed remote builds in B10955: Diff 15077!

Move dockerignore from previous diff

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2022, 6:05 PM
Harbormaster failed remote builds in B10958: Diff 15080!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2022, 6:27 PM
Harbormaster failed remote builds in B10959: Diff 15081!

Fix boost usage with docker workflow

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2022, 7:22 PM
Harbormaster failed remote builds in B10960: Diff 15082!

I know that the CI gates will fail, but can't really do much about it until all of the docker logic is fixed, and would like to avoid pushing many base images.

In D4671#134288, @jon wrote:

I know that the CI gates will fail, but can't really do much about it until all of the docker logic is fixed, and would like to avoid pushing many base images.

Is there a way to point to the base image in the repo instead of DockerHub?

I feel like there's got to be a way, just don't know how involved that would be.

Is there a way to point to the base image in the repo instead of DockerHub?

I'm not sure, currently I have it where the services are pulling from "latest", and just build the image locally (which will automatically tag latest). So the test plan currently does pull from the local repo as docker will prefer items in the local image cache. But I can only "bump" the true version after it's published to dockerhub. I think you can also use image IDs, but that's harder to determine how to create something.

Or we can use nix :)

cd services/base-image
docker build -t commapp/services-base . -f Dockerfile

cd ../..
docker build . -f services/tunnelbroker/Dockerfile

Ran these steps locally and confirmed that they worked.

This revision is now accepted and ready to land.Aug 1 2022, 10:33 AM

Updated base-image tag