Page MenuHomePhabricator
Differential D5019

[services] Backup - Use Blob client in c++ - Implement send log
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 4:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 7:10 AM
Unknown Object (File)
Wed, Mar 19, 1:51 PM
Unknown Object (File)
Sun, Mar 16, 12:23 AM
Unknown Object (File)
Thu, Mar 13, 3:48 PM
Unknown Object (File)
Wed, Mar 5, 8:52 AM
Unknown Object (File)
Tue, Mar 4, 2:54 PM
Unknown Object (File)
Mon, Mar 3, 10:55 PM
Unknown Object (File)
Mon, Mar 3, 6:16 PM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
• max
Commits
rCOMMd92ff5a3dcfd: [services] Backup - Use Blob client in c++ - Implement send log
Summary

Depends on D5018

Adding c++ implementation for using the blob client in the backup reactor for sending logs.

Test Plan

backup builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 4:10 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 4:10 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 1 2022, 4:26 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.
• karol added a child revision: D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.
Harbormaster completed remote builds in B11776: Diff 16179.Sep 1 2022, 4:33 AM
• karol requested review of this revision.Sep 1 2022, 4:33 AM
• karol planned changes to this revision.Sep 2 2022, 5:47 AM
• karol updated this revision to Diff 16247.Sep 2 2022, 5:48 AM

rebase

Harbormaster failed remote builds in B11842: Diff 16247!Sep 2 2022, 5:53 AM
tomek requested changes to this revision.Sep 5 2022, 7:14 AM

Why do we call put_client_blocking_read_cxx a couple of times?

services/backup/src/Reactors/server/SendLogReactor.cpp
120–150

Is this approach correct according to gRPC recommendation? This might take long and is called from a reactor - but we probably should return as soon as possible from these.

This revision now requires changes to proceed.Sep 5 2022, 7:14 AM
• karol requested review of this revision.Sep 6 2022, 3:25 AM
In D5019#146919, @tomek wrote:

Why do we call put_client_blocking_read_cxx a couple of times?

Explained in https://phab.comm.dev/D5017#147269

services/backup/src/Reactors/server/SendLogReactor.cpp
120–150

This is a part of this task, I intentionally left it to fix later https://linear.app/comm/issue/ENG-1724/solve-the-problem-with-blocked-reactors-in-grpc

tomek accepted this revision.Sep 7 2022, 5:30 AM
This revision is now accepted and ready to land.Sep 7 2022, 5:30 AM
• karol updated this revision to Diff 16451.Sep 8 2022, 4:01 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
Closed by commit rCOMMd92ff5a3dcfd: [services] Backup - Use Blob client in c++ - Implement send log (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMd92ff5a3dcfd: [services] Backup - Use Blob client in c++ - Implement send log.
Harbormaster completed remote builds in B11996: Diff 16451.Sep 8 2022, 4:23 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
2 lines
64 lines

Diff 16247

View Options

services/backup/src/Reactors/server/SendLogReactor.h

  • This file was added.
project(comm-services-common)
cmake_minimum_required(VERSION 3.4)
include(GNUInstallDirs)
# Export reactors
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/client-base-reactors)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/server-base-reactors)
file(GLOB COMMON_HDRS
${CMAKE_CURRENT_SOURCE_DIR}/*.h
)
file(GLOB COMMON_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/*.cpp
)
add_library(comm-services-common
${COMMON_HDRS}
${COMMON_SRCS}
)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(protobuf REQUIRED)
find_package(gRPC REQUIRED)
target_link_libraries(comm-services-common
gRPC::grpc++
${AWSSDK_LINK_LIBRARIES}
)
# reference local directory when building, use installation path when installing
target_include_directories(comm-services-common
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)
install(TARGETS comm-services-common EXPORT comm-services-common-export
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT comm-services-common
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
)
install(FILES ${COMMON_HDRS} DESTINATION include)
# For development purposes, can point cmake to this directory if doing development
export(TARGETS comm-services-common
NAMESPACE comm-services-common::
FILE ${CMAKE_CURRENT_BINARY_DIR}/cmake/comm-services-common/comm-services-common-targets.cmake
)
# For installation
install(EXPORT comm-services-common-export
FILE comm-services-common-targets.cmake
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/comm-tool
NAMESPACE comm-services-common::
)
View Options

services/backup/src/Reactors/server/SendLogReactor.cpp

  • This file was added.
project(comm-services-common)
cmake_minimum_required(VERSION 3.4)
include(GNUInstallDirs)
# Export reactors
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/client-base-reactors)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/server-base-reactors)
file(GLOB COMMON_HDRS
${CMAKE_CURRENT_SOURCE_DIR}/*.h
)
file(GLOB COMMON_SRCS
${CMAKE_CURRENT_SOURCE_DIR}/*.cpp
)
add_library(comm-services-common
${COMMON_HDRS}
${COMMON_SRCS}
)
find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)
find_package(protobuf REQUIRED)
find_package(gRPC REQUIRED)
target_link_libraries(comm-services-common
gRPC::grpc++
${AWSSDK_LINK_LIBRARIES}
)
# reference local directory when building, use installation path when installing
target_include_directories(comm-services-common
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)
install(TARGETS comm-services-common EXPORT comm-services-common-export
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT comm-services-common
LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} COMPONENT comm-services-common
)
install(FILES ${COMMON_HDRS} DESTINATION include)
# For development purposes, can point cmake to this directory if doing development
export(TARGETS comm-services-common
NAMESPACE comm-services-common::
FILE ${CMAKE_CURRENT_BINARY_DIR}/cmake/comm-services-common/comm-services-common-targets.cmake
)
# For installation
install(EXPORT comm-services-common-export
FILE comm-services-common-targets.cmake
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/comm-tool
NAMESPACE comm-services-common::
)