Page MenuHomePhabricator
Differential D8748

[Identity] Issue refresh_key_request to tunnelbroker
ClosedPublic
Actions

Authored by • jon on Aug 7 2023, 7:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 3:33 PM
Unknown Object (File)
Sat, Mar 8, 7:08 AM
Unknown Object (File)
Sat, Mar 8, 7:08 AM
Unknown Object (File)
Sat, Mar 8, 7:08 AM
Unknown Object (File)
Sat, Mar 8, 7:08 AM
Unknown Object (File)
Sat, Mar 8, 7:07 AM
Unknown Object (File)
Sat, Mar 8, 6:59 AM
Unknown Object (File)
Mar 1 2025, 11:08 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM3727b2debecb: [Identity] Issue refresh_key_request to tunnelbroker
Summary

Have identity service issue a request to users when refresh keys
when the key count goes below the threshold.

https://linear.app/comm/issue/ENG-4446

Depends on D8723

Test Plan

Integration tests are in next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Aug 7 2023, 7:51 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 7 2023, 7:51 AM
• jon added a child revision: D8749: [Identity/Tunnelbroker] Add integration tests.Aug 7 2023, 7:54 AM
Harbormaster completed remote builds in B21563: Diff 29584.Aug 7 2023, 8:09 AM
• jon requested review of this revision.Aug 7 2023, 8:09 AM
bartek added inline comments.Aug 7 2023, 8:41 AM
services/identity/src/database.rs
388–389

Do we have to wait for these? Can it be done concurrently, without blocking the single onetime key acquisition?

• jon added inline comments.Aug 7 2023, 9:21 AM
services/identity/src/database.rs
388–389

It needs to be awaited (futures that aren't awaited never get executed). But could probably do something like tokio::spawn to move it to a different thread. It my plan originally, but I just wanted something easier to reason about while implementing this.

The other item I thought of, and is probably a better solution, would be to introduce a mpsc channel to a dedicated tunnelbroker channel. It would also avoid the overhead of a connection for every request.

390

This is just to avoid the "Result not inspected" warning. It will emit the error in logs.

• jon added a child revision: D8752: [Keyserver] Upload new onetime keys to identity service when requested.Aug 8 2023, 8:56 AM
bartek added inline comments.Aug 16 2023, 5:17 AM
services/identity/src/database.rs
387–390

Yep, let's try tokio::spawn and see if it works

The other item I thought of, and is probably a better solution, would be to introduce a mpsc channel to a dedicated tunnelbroker channel. It would also avoid the overhead of a connection for every request.

Good idea. This can be done as a follow-up I think.

varun accepted this revision.Aug 16 2023, 7:46 AM
varun added 1 blocking reviewer(s): bartek.

some nits/comments inline. adding @bartek as blocking so the tokio::spawn change gets added

services/identity/src/constants.rs
131–133

how did we decide on these values?

131–133

ONE_TIME_KEY_...

services/identity/src/database.rs
379–385
• jon updated this revision to Diff 30024.Aug 17 2023, 10:05 AM
• jon marked 5 inline comments as done.

Apply suggestions

services/identity/src/constants.rs
131–133

how did we decide on these values?

It was pretty informal, I think a one-on-one or some crypto sync. Don't think it was ever documented.

I just need something though to start with. We can discuss this as part of a crypto sync if you do have concerns. I don't think I'm informed enough to know what the correct numbers would be.

ONE_TIME_KEY_...

This is address treewide in D8817

services/identity/src/database.rs
379–385

After realizing that my let-else issues were related to not running rustup update since February, I decided to use @bartek suggestion.

bartek accepted this revision.Aug 17 2023, 10:12 AM
This revision is now accepted and ready to land.Aug 17 2023, 10:12 AM
Harbormaster completed remote builds in B21850: Diff 30024.Aug 17 2023, 10:23 AM
• jon updated this revision to Diff 30031.Aug 17 2023, 10:25 AM

Rebase on master

Harbormaster completed remote builds in B21857: Diff 30031.Aug 17 2023, 10:44 AM
varun accepted this revision.Aug 17 2023, 12:04 PM
Closed by commit rCOMM3727b2debecb: [Identity] Issue refresh_key_request to tunnelbroker (authored by • jon). · Explain WhyAug 20 2023, 11:49 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM3727b2debecb: [Identity] Issue refresh_key_request to tunnelbroker.

Revision Contents
Changeset List

PathSize
services/
identity/
1 line
7 lines
src/
7 lines
12 lines
14 lines
1 line
48 lines

Diff 29584

View Options

services/identity/Cargo.lock

Show First 20 Lines • Show All 248 Lines • ▼ Show 20 Lines if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<RootNavigator /> <RootNavigator />
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider initialMetrics={initialWindowMetrics}>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider persistence={filesystemMediaCache}> <MediaCacheProvider persistence={filesystemMediaCache}>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<ChatContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<Socket <Socket
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</MessageSearchProvider> </MessageSearchProvider>
</ChatContextProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
Show All 25 Lines
View Options

services/identity/Cargo.toml

Show First 20 Lines • Show All 248 Lines • ▼ Show 20 Lines if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<RootNavigator /> <RootNavigator />
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider initialMetrics={initialWindowMetrics}>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider persistence={filesystemMediaCache}> <MediaCacheProvider persistence={filesystemMediaCache}>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<ChatContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<Socket <Socket
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</MessageSearchProvider> </MessageSearchProvider>
</ChatContextProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
Show All 25 Lines
View Options

services/identity/build.rs

Show First 20 Lines • Show All 248 Lines • ▼ Show 20 Lines if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<RootNavigator /> <RootNavigator />
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider initialMetrics={initialWindowMetrics}>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider persistence={filesystemMediaCache}> <MediaCacheProvider persistence={filesystemMediaCache}>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<ChatContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<Socket <Socket
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</MessageSearchProvider> </MessageSearchProvider>
</ChatContextProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
Show All 25 Lines
View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 248 Lines • ▼ Show 20 Lines if (initialState) {
navigation = ( navigation = (
<NavigationContainer <NavigationContainer
initialState={initialState} initialState={initialState}
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<RootNavigator /> <RootNavigator />
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider initialMetrics={initialWindowMetrics}>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider persistence={filesystemMediaCache}> <MediaCacheProvider persistence={filesystemMediaCache}>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<ChatContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<Socket <Socket
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</MessageSearchProvider> </MessageSearchProvider>
</ChatContextProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
Show All 25 Lines
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/error.rs

Loading...
View Options

services/identity/src/main.rs

Loading...
View Options

services/identity/src/tunnelbroker.rs

Loading...