Differential D8751

[Keyserver] Refactor getOneTimeKeyValues
ClosedPublic
Actions

Authored by kamil on Aug 7 2023, 8:21 AM.

Tags

None

Referenced Files

	F1721715: D8751.diff
	Thu, May 9, 3:11 PM

	Unknown Object (File)
	Tue, May 7, 10:17 PM

	Unknown Object (File)
	Tue, May 7, 10:17 PM

	Unknown Object (File)
	Tue, May 7, 10:17 PM

	Unknown Object (File)
	Sat, May 4, 5:08 PM

	Unknown Object (File)
	Sat, May 4, 5:08 PM

	Unknown Object (File)
	Sat, May 4, 5:08 PM

	Unknown Object (File)
	Sat, May 4, 12:04 PM

Subscribers

Details

Reviewers

marcin
• jon

Commits

rCOMM0d30bbfc847b: [Keyserver] Refactor getOneTimeKeyValues

Summary

This is useful for more than the current login workflow,
refactor to separate file

In support of https://linear.app/comm/issue/ENG-4602

Depends on D8750

Test Plan

# Start localstack and rabbitmq
comm-dev services start

(cd services/identity && cargo run -- server)
(cd services/tunnelbroker && cargo run)

# If keyserver has already logged in, reset user_id entry in metadata table
# This will force keyserver to re-login

cd keyserver
yarn dev

# Assert the user is populated in MariaDB

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 7 2023, 8:21 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 7 2023, 8:21 AM

• jon added a child revision: D8752: [Keyserver] Upload new onetime keys to identity service when requested.Aug 7 2023, 8:25 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2023, 8:36 AM

Harbormaster failed remote builds in B21567: Diff 29591!

Fix type import

Harbormaster completed remote builds in B21852: Diff 30026.Aug 17 2023, 10:36 AM

• jon requested review of this revision.Aug 17 2023, 10:36 AM

marcin accepted this revision.Aug 21 2023, 1:54 AM

This revision is now accepted and ready to land.Aug 21 2023, 1:54 AM

kamil commandeered this revision.Sep 8 2023, 7:32 AM

kamil edited reviewers, added: • jon; removed: kamil.

ashoat mentioned this in D9129: [lib] utility function to get array of OneTimeKeys from an OLMOneTimeKeys object.Sep 12 2023, 11:28 AM

rebase before landing

Harbormaster completed remote builds in B22581: Diff 31034.Sep 13 2023, 6:17 AM

Closed by commit rCOMM0d30bbfc847b: [Keyserver] Refactor getOneTimeKeyValues (authored by • jon, committed by kamil). · Explain WhySep 13 2023, 6:43 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0d30bbfc847b: [Keyserver] Refactor getOneTimeKeyValues.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

user/

12 lines

utils/

12 lines

Diff 30026

keyserver/src/user/login.js

Loading...

keyserver/src/utils/olm-utils.js

Loading...