Details

Reviewers

bartek
varun

Commits

rCOMMaf2aa087b832: [Treewide] Rename onetime to one_time

Summary

"oneTime" is the language used in the white paper. Make this
consistent between all call sites.

https://linear.app/comm/issue/ENG-4642

Depends on D8816

Test Plan

everything builds.
Run one time integration tests

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/keyserver-identity-only (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Aug 15 2023, 10:02 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 10:02 AM

Harbormaster completed remote builds in B21760: Diff 29913.Aug 15 2023, 10:20 AM

• jon requested review of this revision.Aug 15 2023, 10:20 AM

Missed some comments

services/identity/src/database.rs
388
390
404

Fix some missed comments

Harbormaster completed remote builds in B21768: Diff 29921.Aug 15 2023, 11:09 AM

bartek accepted this revision.Aug 16 2023, 5:22 AM

This revision is now accepted and ready to land.Aug 16 2023, 5:22 AM

• jon mentioned this in D8748: [Identity] Issue refresh_key_request to tunnelbroker.Aug 17 2023, 10:05 AM

Rebase on changes to previous diffs

Harbormaster failed remote builds in B21851: Diff 30025!Aug 17 2023, 10:13 AM

Apply rename to new code from previous diff feedback

Harbormaster completed remote builds in B21862: Diff 30036.Aug 17 2023, 10:57 AM

• jon added a child revision: D8878: [Identity] Show consumed capacity when running query.Aug 20 2023, 11:32 PM

Rebase after conflict changes in previous diff

Harbormaster completed remote builds in B22052: Diff 30272.Aug 23 2023, 10:44 AM

Rebase on top of master

Harbormaster completed remote builds in B22106: Diff 30340.Aug 25 2023, 5:11 PM

Fixed miss rename

Harbormaster completed remote builds in B22151: Diff 30410.Aug 27 2023, 10:43 PM

Closed by commit rCOMMaf2aa087b832: [Treewide] Rename onetime to one_time (authored by • jon). · Explain WhyAug 27 2023, 11:59 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMaf2aa087b832: [Treewide] Rename onetime to one_time.

[Treewide] Rename onetime to one_time
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 29913

keyserver/addons/rust-node-addon/src/identity_client/login.rs

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

native/native_rust_library/src/identity_client.rs

native/native_rust_library/src/lib.rs

services/commtest/src/identity/device.rs

services/commtest/tests/identity_keyserver_tests.rs

services/identity/src/client_service.rs

services/identity/src/constants.rs

services/identity/src/database.rs

services/identity/src/grpc_services/authenticated.rs

services/identity/src/tunnelbroker.rs

shared/protos/identity_authenticated.proto

shared/protos/identity_client.proto

[Treewide] Rename onetime to one_timeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29913

keyserver/addons/rust-node-addon/src/identity_client/login.rs

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

native/native_rust_library/src/identity_client.rs

native/native_rust_library/src/lib.rs

services/commtest/src/identity/device.rs

services/commtest/tests/identity_keyserver_tests.rs

services/identity/src/client_service.rs

services/identity/src/constants.rs

services/identity/src/database.rs

services/identity/src/grpc_services/authenticated.rs

services/identity/src/tunnelbroker.rs

shared/protos/identity_authenticated.proto

shared/protos/identity_client.proto

[Treewide] Rename onetime to one_time
ClosedPublic
Actions

Revision Contents
Changeset List