[lib] Add top-level group chats to GENESIS chat mention candidates object
ClosedPublic
Actions

Authored by • patryk on Sep 27 2023, 11:13 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM54b69386a10a: [lib] Add top-level group chats to GENESIS chat mention candidates object

Summary

This diff resolves this comment. Chats which have more than two users and are
the first child of GENESIS community are added to GENESIS chat mention candidates object.

Depends on D9218.

Test Plan

Check if first-child chats with type LOCAL are added to GENESIS chat mention candidates object by adding a console.log to chatMentionCandidates selector.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Sep 27 2023, 11:13 AM

• patryk held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 27 2023, 11:13 AM

Harbormaster completed remote builds in B22872: Diff 31459.Sep 27 2023, 11:32 AM

• patryk published this revision for review.Sep 28 2023, 12:44 AM

• patryk edited the summary of this revision. (Show Details)

• patryk added a parent revision: D9218: [keyserver] Render raw chat mention in the notification text.

Change cond

tomek accepted this revision.Sep 28 2023, 5:19 AM

This revision is now accepted and ready to land.Sep 28 2023, 5:19 AM

Harbormaster completed remote builds in B22888: Diff 31505.Sep 28 2023, 5:36 AM

Closed by commit rCOMM54b69386a10a: [lib] Add top-level group chats to GENESIS chat mention candidates object (authored by • patryk). · Explain WhySep 28 2023, 5:59 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM54b69386a10a: [lib] Add top-level group chats to GENESIS chat mention candidates object.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

7 lines

Diff 31518

View Options

lib/shared/thread-utils.js

Show All 27 Lines
import createIDs from './id-creator.js';		import createIDs from './id-creator.js';
import createMessages from './message-creator.js';		import createMessages from './message-creator.js';
import {		import {
createInitialRolesForNewThread,		createInitialRolesForNewThread,
getRolePermissionBlobs,		getRolePermissionBlobs,
} from './role-creator.js';		} from './role-creator.js';
import type { UpdatesForCurrentSession } from './update-creator.js';		import type { UpdatesForCurrentSession } from './update-creator.js';
import { dbQuery, SQL } from '../database/database.js';		import { dbQuery, SQL } from '../database/database.js';
import { fetchMessageInfoByID } from '../fetchers/message-fetchers.js';		import {
		fetchLatestEditMessageContentByID,
		fetchMessageInfoByID,
		} from '../fetchers/message-fetchers.js';
import {		import {
determineThreadAncestry,		determineThreadAncestry,
personalThreadQuery,		personalThreadQuery,
} from '../fetchers/thread-fetchers.js';		} from '../fetchers/thread-fetchers.js';
import {		import {
checkThreadPermission,		checkThreadPermission,
validateCandidateMembers,		validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js';		} from '../fetchers/thread-permission-fetchers.js';
▲ Show 20 Lines • Show All 371 Lines • ▼ Show 20 Lines	messageDatas.push({
},		},
});		});
} else {		} else {
invariant(parentThreadID, 'parentThreadID should be set for sidebar');		invariant(parentThreadID, 'parentThreadID should be set for sidebar');
if (!sourceMessage \|\| sourceMessage.type === messageTypes.SIDEBAR_SOURCE) {		if (!sourceMessage \|\| sourceMessage.type === messageTypes.SIDEBAR_SOURCE) {
throw new ServerError('invalid_parameters');		throw new ServerError('invalid_parameters');
}		}

		let editedSourceMessage = sourceMessage;
		if (sourceMessageID && sourceMessage.type === messageTypes.TEXT) {
		const editMessageContent = await fetchLatestEditMessageContentByID(
		sourceMessageID,
		);
		if (editMessageContent) {
		editedSourceMessage = {
		...sourceMessage,
		text: editMessageContent.text,
		};
		}
		}

messageDatas.push(		messageDatas.push(
{		{
type: messageTypes.SIDEBAR_SOURCE,		type: messageTypes.SIDEBAR_SOURCE,
threadID: id,		threadID: id,
creatorID: viewer.userID,		creatorID: viewer.userID,
time,		time,
sourceMessage,		sourceMessage: editedSourceMessage,
},		},
{		{
type: messageTypes.CREATE_SIDEBAR,		type: messageTypes.CREATE_SIDEBAR,
threadID: id,		threadID: id,
creatorID: viewer.userID,		creatorID: viewer.userID,
time,		time,
sourceMessageAuthorID: sourceMessage.creatorID,		sourceMessageAuthorID: sourceMessage.creatorID,
initialThreadState: {		initialThreadState: {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines

[lib] Add top-level group chats to GENESIS chat mention candidates objectClosedPublicActions