Page MenuHomePhabricator
Differential D8877

[web] Fix spoiler animation for links
ClosedPublic
Actions

Authored by • patryk on Aug 20 2023, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:16 PM
Unknown Object (File)
Fri, Nov 8, 4:16 PM
Unknown Object (File)
Fri, Nov 8, 4:08 PM
Unknown Object (File)
Fri, Nov 8, 3:59 PM
Unknown Object (File)
Wed, Nov 6, 9:46 PM
Unknown Object (File)
Sat, Nov 2, 2:05 PM
Unknown Object (File)
Oct 12 2024, 12:07 PM
Unknown Object (File)
Oct 2 2024, 1:21 AM
View All 62 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM2e9c0b06d51f: [web] Fix spoiler animation for links
Summary

Solution for ENG-4676

This diff fixes the issue where spoiler reveal animation was not applied to links.

Depends on D8875.

Test Plan
  1. Before applying this patch, check if current spoiler reveal animation doesn't work for links:

  1. Apply this patch and see if animation works for links too:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 20 2023, 6:49 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 20 2023, 6:49 AM
• patryk added a child revision: D8876: [web] Inherit colors on spoiler reveal animation.Aug 20 2023, 6:51 AM
• patryk edited the summary of this revision. (Show Details)
• patryk added a parent revision: D8875: [web] Make chat mentions clickable.
Harbormaster completed remote builds in B21925: Diff 30112.Aug 20 2023, 7:07 AM
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 8:51 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka, rohan.
• patryk attached a referenced file: F698082: before link patch web.mp4. (Show Details)Aug 20 2023, 11:09 PM
• patryk attached a referenced file: F698083: after link patch web.mp4. (Show Details)
• patryk published this revision for review.Aug 20 2023, 11:14 PM
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 11:33 PM
inka accepted this revision.Aug 21 2023, 4:21 AM
This revision is now accepted and ready to land.Aug 21 2023, 4:21 AM
ashoat added a comment.Aug 21 2023, 9:21 AM

Thanks for taking the time to improve the codebase, even though it doesn't pertain to your work exactly :)

rohan accepted this revision.Aug 21 2023, 5:10 PM

Good catch, thanks for fixing this!

Closed by commit rCOMM2e9c0b06d51f: [web] Fix spoiler animation for links (authored by • patryk). · Explain WhySep 28 2023, 2:10 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM2e9c0b06d51f: [web] Fix spoiler animation for links.

Revision Contents
Changeset List

PathSize
web/
markdown/
3 lines

Diff 31496

View Options

web/markdown/markdown.css

Loading...