Differential D8898 Authored by • patryk on Aug 22 2023, 2:01 AM.
Details Summary We need to distinguish user mentions from chat mentions so it's necessary to rename functions and variables which names are too generic. Also added word "mention" to typeahead tooltip utilities -> typeahead can be used not only for mentioning, so we should also indicate that. Depends on D8897. Test Plan Check if there are no typos and if every affected part of code works properly.
Diff Detail
Event Timeline• patryk held this revision as a draft. Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 2:01 AM2023-08-22 02:01:31 (UTC-7) Harbormaster completed remote builds in B21980: Diff 30182.Aug 22 2023, 2:18 AM2023-08-22 02:18:10 (UTC-7) • patryk edited the summary of this revision. (Show Details)Aug 22 2023, 2:39 AM2023-08-22 02:39:26 (UTC-7) • patryk edited the summary of this revision. (Show Details)Aug 22 2023, 3:17 AM2023-08-22 03:17:24 (UTC-7) This revision is now accepted and ready to land.Aug 24 2023, 7:15 AM2023-08-24 07:15:32 (UTC-7) Harbormaster completed remote builds in B22062: Diff 30286.Aug 24 2023, 2:01 PM2023-08-24 14:01:23 (UTC-7) Harbormaster completed remote builds in B22300: Diff 30625.Aug 31 2023, 2:45 AM2023-08-31 02:45:47 (UTC-7) Harbormaster completed remote builds in B22715: Diff 31251.Sep 19 2023, 3:04 AM2023-09-19 03:04:15 (UTC-7) Closed by commit rCOMMf07596e39996: [web][native] Modify typeahead function and variable names to distinguish chat… (authored by • patryk). · Explain WhySep 28 2023, 2:43 AM2023-09-28 02:43:08 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 31501 |