Page MenuHomePhabricator

[web][native] Modify typeahead function and variable names to distinguish chat mention utilities
AcceptedPublic

Authored by patryk on Aug 22 2023, 2:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 14, 11:59 PM
Unknown Object (File)
Tue, Sep 12, 2:05 PM
Unknown Object (File)
Wed, Sep 6, 7:12 PM
Unknown Object (File)
Sat, Sep 2, 12:49 PM
Unknown Object (File)
Sat, Sep 2, 7:14 AM
Unknown Object (File)
Thu, Aug 31, 4:54 PM
Unknown Object (File)
Wed, Aug 30, 2:29 PM
Unknown Object (File)
Tue, Aug 29, 4:12 AM
Subscribers

Details

Reviewers
tomek
inka
rohan
Summary

We need to distinguish user mentions from chat mentions so it's necessary to rename functions and variables which names are too generic. Also added word "mention" to typeahead tooltip utilities -> typeahead can be used not only for mentioning, so we should also indicate that.

Depends on D8897.

Test Plan

Check if there are no typos and if every affected part of code works properly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka.
patryk published this revision for review.Aug 22 2023, 8:37 AM

Seems reasonable to me

This revision is now accepted and ready to land.Aug 24 2023, 7:15 AM