Page MenuHomePhabricator

[lib] Add unit tests for chat mention regex
AcceptedPublic

Authored by patryk on Thu, Aug 31, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 16, 12:57 AM
Unknown Object (File)
Fri, Sep 15, 9:57 AM
Unknown Object (File)
Fri, Sep 15, 9:08 AM
Unknown Object (File)
Thu, Sep 14, 9:57 PM
Unknown Object (File)
Sun, Sep 10, 7:36 PM
Unknown Object (File)
Sat, Sep 2, 12:41 PM
Subscribers

Details

Reviewers
tomek
inka
rohan
Summary

This diff adds chat mention regex unit tests to markdown.test.js.

Depends on D8834.

Test Plan

Run yarn test in lib folder and check if all tests pass.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka, rohan.
patryk edited the summary of this revision. (Show Details)
patryk published this revision for review.Thu, Aug 31, 11:53 PM

Thanks for doing this!! Tests look great. I think outside of this file the pattern is to typically use it('should...), but I don't think it's a big deal

lib/shared/markdown.test.js
120 ↗(On Diff #30689)
124 ↗(On Diff #30689)
This revision is now accepted and ready to land.Fri, Sep 1, 7:24 AM