Page MenuHomePhabricator
Differential D9061

[lib][native][web] Move validChatNameRegex to validation-utils.js
AcceptedPublic
Actions

Authored by patryk on Fri, Sep 1, 5:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 23, 6:30 PM
Unknown Object (File)
Fri, Sep 22, 12:51 AM
Unknown Object (File)
Sun, Sep 17, 12:42 AM
Unknown Object (File)
Sat, Sep 2, 12:41 PM
F737992: error2.png
Fri, Sep 1, 5:28 AM
Subscribers
ashoat
rohan
tomek

Details

Reviewers
tomek
inka
rohan
Summary

This diff resolves the ReferenceError issue on web, which was occurring after the introduction of D8834.

error2.png (409×511 px, 85 KB)

Depends on D8945.

Test Plan

Check if all files import validChatNameRegex, validChatNameRegexString, chatNameMaxLength from validation-utils.js

Diff Detail

Repository
rCOMM Comm
Branch
patryk/chat-mentioning-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk created this revision.Fri, Sep 1, 5:22 AM
patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Sep 1, 5:22 AM
patryk edited the summary of this revision. (Show Details)Fri, Sep 1, 5:28 AM
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka.
patryk attached a referenced file: F737992: error2.png. (Show Details)
Harbormaster completed remote builds in B22343: Diff 30695.Fri, Sep 1, 5:40 AM
patryk edited the summary of this revision. (Show Details)Fri, Sep 1, 5:41 AM
patryk edited the test plan for this revision. (Show Details)

Why moving this to validation-utils.js and not to other file?

validChatNameRegex has a word valid => validation => validation-utils.js

patryk edited the summary of this revision. (Show Details)Fri, Sep 1, 5:43 AM
patryk added a parent revision: D9007: [keyserver] Render chat mention in notification text.
patryk published this revision for review.Fri, Sep 1, 5:46 AM
patryk edited the summary of this revision. (Show Details)
patryk added a parent revision: D8945: [web] Show chats in mention typeahead tooltip.
patryk removed a parent revision: D9007: [keyserver] Render chat mention in notification text.
rohan accepted this revision.Fri, Sep 1, 7:20 AM
rohan added a subscriber: rohan.

Didn't review this super closely, seems like just a move

This revision is now accepted and ready to land.Fri, Sep 1, 7:20 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
2 lines
lib/
shared/
8 lines
9 lines
utils/
9 lines
native/
chat/
settings/
2 lines
utils/
2 lines
web/
modals/
threads/
settings/
6 lines
utils/
2 lines

Diff 30695

View Options

keyserver/src/updaters/thread-updaters.js

Loading...
View Options

lib/shared/mention-utils.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/utils/validation-utils.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

native/utils/typeahead-utils.js

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...
View Options

web/utils/typeahead-utils.js

Loading...