Page MenuHomePhabricator

[lib][native][web] Move validChatNameRegex to validation-utils.js
ClosedPublic

Authored by patryk on Sep 1 2023, 5:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 12, 12:27 PM
Unknown Object (File)
Fri, Jul 12, 12:26 PM
Unknown Object (File)
Fri, Jul 12, 12:26 PM
Unknown Object (File)
Fri, Jul 12, 10:59 AM
Unknown Object (File)
Fri, Jul 12, 10:59 AM
Unknown Object (File)
Fri, Jul 12, 10:58 AM
Unknown Object (File)
Fri, Jul 12, 6:35 AM
Unknown Object (File)
Tue, Jul 9, 4:25 PM
Subscribers

Details

Summary

This diff resolves the ReferenceError issue on web, which was occurring after the introduction of D8834.

error2.png (409×511 px, 85 KB)

Depends on D8945.

Test Plan

Check if all files import validChatNameRegex, validChatNameRegexString, chatNameMaxLength from validation-utils.js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka.
patryk attached a referenced file: F737992: error2.png. (Show Details)
patryk edited the test plan for this revision. (Show Details)

Why moving this to validation-utils.js and not to other file?

validChatNameRegex has a word valid => validation => validation-utils.js

rohan added a subscriber: rohan.

Didn't review this super closely, seems like just a move

This revision is now accepted and ready to land.Sep 1 2023, 7:20 AM