Paths

Table of Contentst

[web] Modify mention typeahead regex
ClosedPublic
Actions

Authored by • patryk on Aug 25 2023, 10:11 AM.

Details

Reviewers

tomek
inka
rohan

Commits

rCOMM767028e40c32: [web] Modify mention typeahead regex

Summary

This diff modifies mention typeahead regex on web to support chat mentioning.

Depends on D8943.

Test Plan

Tested later in the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 25 2023, 10:11 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 25 2023, 10:11 AM

• patryk edited the summary of this revision. (Show Details)Aug 25 2023, 10:16 AM

• patryk added reviewers: tomek, inka, rohan.

• patryk added a parent revision: D8943: [web] Refactor TypeaheadTooltip component.

• patryk added a child revision: D8945: [web] Show chats in mention typeahead tooltip.

• patryk edited the summary of this revision. (Show Details)Aug 25 2023, 10:23 AM

• patryk edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B22080: Diff 30308.Aug 25 2023, 10:29 AM

• patryk published this revision for review.Aug 25 2023, 11:01 AM

• patryk added inline comments.

web/utils/typeahead-utils.js
22 ↗	(On Diff #30308)	Potential drawbacks of this solution are described here.

I think it'll be useful to add some unit tests for this regex, alongside the regex in D8834

inka added inline comments.Sep 6 2023, 8:45 AM

web/utils/typeahead-utils.js
22 ↗	(On Diff #30308)	Is there any point is using an alternative here? Isn't `oldValidUsernameRegexString` a subset of `validChatNameRegexString`?

Remove oldValidUsernameRegexString.

Harbormaster completed remote builds in B22719: Diff 31255.Sep 19 2023, 11:05 AM

In D8944#263772, @rohan wrote:

I think it'll be useful to add some unit tests for this regex, alongside the regex in D8834

This comment doesn't appear to have been addressed

D9057

inka accepted this revision.Sep 22 2023, 2:32 PM

This revision is now accepted and ready to land.Sep 22 2023, 2:32 PM

Closed by commit rCOMM767028e40c32: [web] Modify mention typeahead regex. · Explain WhySep 28 2023, 12:43 PM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM767028e40c32: [web] Modify mention typeahead regex.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-input-bar.react.js

2 lines

utils/

typeahead-utils.js

4 lines

Diff 31512

View Options

web/chat/chat-input-bar.react.js