Page MenuHomePhabricator
Differential D9057

[web] Add webMentionTypeaheadRegex tests
ClosedPublic
Actions

Authored by • patryk on Aug 31 2023, 2:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 3:22 AM
Unknown Object (File)
Mon, Mar 17, 3:21 AM
Unknown Object (File)
Sat, Mar 15, 8:35 PM
Unknown Object (File)
Fri, Mar 7, 5:08 PM
Unknown Object (File)
Tue, Feb 25, 3:32 PM
Unknown Object (File)
Tue, Feb 25, 7:30 AM
Unknown Object (File)
Tue, Feb 25, 7:30 AM
Unknown Object (File)
Tue, Feb 25, 7:30 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
rohan
Commits
rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests
Summary

This diff adds webMentionTypeaheadRegex regex unit tests to typeahead-utils.test.js.

Depends on D9056.

Test Plan

Run yarn test in web folder and check if all tests pass.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 31 2023, 2:49 PM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2023, 2:49 PM
• patryk edited the summary of this revision. (Show Details)Aug 31 2023, 2:55 PM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka, rohan.
• patryk added a parent revision: D9056: [lib] Add unit tests for chat mention regex.
Harbormaster completed remote builds in B22329: Diff 30681.Aug 31 2023, 3:08 PM
inka mentioned this in D8834: [lib] Introduce chat mention match and parse utilities.Sep 6 2023, 2:37 AM
• patryk updated this revision to Diff 31337.Sep 21 2023, 7:47 AM

Add more tests

• patryk updated this revision to Diff 31338.Sep 21 2023, 7:52 AM

Change text

• patryk published this revision for review.Sep 21 2023, 7:53 AM
Harbormaster completed remote builds in B22778: Diff 31337.Sep 21 2023, 8:06 AM
Harbormaster completed remote builds in B22779: Diff 31338.Sep 21 2023, 8:09 AM
inka accepted this revision.Sep 22 2023, 6:45 AM
This revision is now accepted and ready to land.Sep 22 2023, 6:45 AM
• patryk mentioned this in D8944: [web] Modify mention typeahead regex.Sep 22 2023, 7:29 AM
inka added a comment.Sep 22 2023, 7:32 AM

You could remove the text field and just do textPrefix + mentionText

• patryk updated this revision to Diff 31371.Sep 22 2023, 7:44 AM

Simplify test cases

Harbormaster completed remote builds in B22803: Diff 31371.Sep 22 2023, 8:02 AM
Closed by commit rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests (authored by • patryk). · Explain WhySep 28 2023, 5:59 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests.

Revision Contents
Changeset List

PathSize
web/
utils/
70 lines

Diff 31519

View Options

web/utils/typeahead-utils.test.js

Show All 27 Lines
import createIDs from './id-creator.js'; import createIDs from './id-creator.js';
import createMessages from './message-creator.js'; import createMessages from './message-creator.js';
import { import {
createInitialRolesForNewThread, createInitialRolesForNewThread,
getRolePermissionBlobs, getRolePermissionBlobs,
} from './role-creator.js'; } from './role-creator.js';
import type { UpdatesForCurrentSession } from './update-creator.js'; import type { UpdatesForCurrentSession } from './update-creator.js';
import { dbQuery, SQL } from '../database/database.js'; import { dbQuery, SQL } from '../database/database.js';
import { fetchMessageInfoByID } from '../fetchers/message-fetchers.js'; import {
fetchLatestEditMessageContentByID,
fetchMessageInfoByID,
} from '../fetchers/message-fetchers.js';
import { import {
determineThreadAncestry, determineThreadAncestry,
personalThreadQuery, personalThreadQuery,
} from '../fetchers/thread-fetchers.js'; } from '../fetchers/thread-fetchers.js';
import { import {
checkThreadPermission, checkThreadPermission,
validateCandidateMembers, validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js'; } from '../fetchers/thread-permission-fetchers.js';
▲ Show 20 Lines • Show All 371 Lines • ▼ Show 20 Lines messageDatas.push({
}, },
}); });
} else { } else {
invariant(parentThreadID, 'parentThreadID should be set for sidebar'); invariant(parentThreadID, 'parentThreadID should be set for sidebar');
if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) { if (!sourceMessage || sourceMessage.type === messageTypes.SIDEBAR_SOURCE) {
throw new ServerError('invalid_parameters'); throw new ServerError('invalid_parameters');
} }
let editedSourceMessage = sourceMessage;
if (sourceMessageID && sourceMessage.type === messageTypes.TEXT) {
const editMessageContent = await fetchLatestEditMessageContentByID(
sourceMessageID,
);
if (editMessageContent) {
editedSourceMessage = {
...sourceMessage,
text: editMessageContent.text,
};
}
}
messageDatas.push( messageDatas.push(
{ {
type: messageTypes.SIDEBAR_SOURCE, type: messageTypes.SIDEBAR_SOURCE,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessage, sourceMessage: editedSourceMessage,
}, },
{ {
type: messageTypes.CREATE_SIDEBAR, type: messageTypes.CREATE_SIDEBAR,
threadID: id, threadID: id,
creatorID: viewer.userID, creatorID: viewer.userID,
time, time,
sourceMessageAuthorID: sourceMessage.creatorID, sourceMessageAuthorID: sourceMessage.creatorID,
initialThreadState: { initialThreadState: {
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines