Details

Reviewers

tomek
inka
rohan

Commits

rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests

Summary

This diff adds webMentionTypeaheadRegex regex unit tests to typeahead-utils.test.js.

Depends on D9056.

Test Plan

Run yarn test in web folder and check if all tests pass.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 31 2023, 9:49 PM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2023, 9:49 PM

• patryk edited the summary of this revision. (Show Details)Aug 31 2023, 9:55 PM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka, rohan.

• patryk added a parent revision: D9056: [lib] Add unit tests for chat mention regex.

Harbormaster completed remote builds in B22329: Diff 30681.Aug 31 2023, 10:08 PM

inka mentioned this in D8834: [lib] Introduce chat mention match and parse utilities.Sep 6 2023, 9:37 AM

Add more tests

Change text

• patryk published this revision for review.Sep 21 2023, 2:53 PM

Harbormaster completed remote builds in B22778: Diff 31337.Sep 21 2023, 3:06 PM

Harbormaster completed remote builds in B22779: Diff 31338.Sep 21 2023, 3:09 PM

inka accepted this revision.Sep 22 2023, 1:45 PM

This revision is now accepted and ready to land.Sep 22 2023, 1:45 PM

• patryk mentioned this in D8944: [web] Modify mention typeahead regex.Sep 22 2023, 2:29 PM

You could remove the text field and just do textPrefix + mentionText

Simplify test cases

Harbormaster completed remote builds in B22803: Diff 31371.Sep 22 2023, 3:02 PM

Closed by commit rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests. · Explain WhySep 28 2023, 12:59 PM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM6670a2b39999: [web] Add webMentionTypeaheadRegex tests.

[web] Add webMentionTypeaheadRegex tests
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 31519

web/utils/typeahead-utils.test.js

[web] Add webMentionTypeaheadRegex testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31519

web/utils/typeahead-utils.test.js

[web] Add webMentionTypeaheadRegex tests
ClosedPublic
Actions

Revision Contents
Changeset List