Paths

Table of Contentst

Differential D8943

[web] Refactor TypeaheadTooltip component
ClosedPublic
Actions

Authored by • patryk on Aug 25 2023, 3:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 26, 9:06 AM

	Unknown Object (File)
	Thu, May 16, 11:46 AM

	Unknown Object (File)
	Wed, May 1, 3:40 PM

	Unknown Object (File)
	Apr 3 2024, 8:40 AM

	Unknown Object (File)
	Mar 31 2024, 8:33 AM

	Unknown Object (File)
	Mar 31 2024, 8:30 AM

	Unknown Object (File)
	Mar 30 2024, 10:56 AM

	Unknown Object (File)
	Mar 30 2024, 10:55 AM

View All 27 Files

Subscribers

Details

Reviewers

tomek
inka
rohan

Commits

rCOMM172de638a8ae: [web] Refactor TypeaheadTooltip component

Summary

This diff refactors TypeaheadTooltip component, like in D8897. New refactored component reuses new types introduced in that diff.

Depends on D8908.

Test Plan

Check if typeahead tooltip on web works properly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 25 2023, 3:11 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 25 2023, 3:11 AM

• patryk edited the summary of this revision. (Show Details)Aug 25 2023, 3:14 AM

• patryk added reviewers: tomek, inka, rohan.

• patryk added a parent revision: D8908: [lib] Encode chat name in raw chat mention.

• patryk added a child revision: D8944: [web] Modify mention typeahead regex.

• patryk edited the summary of this revision. (Show Details)Aug 25 2023, 3:21 AM

• patryk edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B22079: Diff 30307.Aug 25 2023, 3:28 AM

• patryk edited the summary of this revision. (Show Details)Aug 25 2023, 3:30 AM

• patryk published this revision for review.Aug 25 2023, 4:01 AM

Just 1 question inline, requesting changes so it doesn't get lost in the stack

web/chat/chat-input-bar.react.js
380–382 ↗	(On Diff #30307)	Is there a reason these are imported and just passed in as props? Can they be imported directly in `typehead-tooltip.react.js`?
web/chat/typeahead-tooltip.react.js
28–33 ↗	(On Diff #30307)	If you can just import them directly here, that'd remove the complexity in the props here.

This revision now requires changes to proceed.Aug 29 2023, 10:31 AM

• patryk added inline comments.Aug 30 2023, 12:25 AM

web/chat/chat-input-bar.react.js
380–382 ↗	(On Diff #30307)	This is because in the future, we might want to create another typeahead tooltip that renders buttons with a different style. I have provided an explanation for why it's worth considering this refactoring here.

rohan accepted this revision.Aug 30 2023, 10:23 AM

rohan added inline comments.

web/chat/chat-input-bar.react.js
380–382 ↗	(On Diff #30307)	Ah ok I guess it makes sense to make future work easier

This revision is now accepted and ready to land.Aug 30 2023, 10:23 AM

Closed by commit rCOMM172de638a8ae: [web] Refactor TypeaheadTooltip component (authored by • patryk). · Explain WhySep 28 2023, 5:40 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM172de638a8ae: [web] Refactor TypeaheadTooltip component.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-input-bar.react.js

47 lines

typeahead-tooltip.react.js

52 lines

utils/

typeahead-utils.js

107 lines

Diff 31511

web/chat/chat-input-bar.react.js

Loading...

web/chat/typeahead-tooltip.react.js

Loading...

web/utils/typeahead-utils.js

Loading...